Skip to content
Snippets Groups Projects
  1. Nov 16, 2020
  2. Nov 15, 2020
  3. Nov 13, 2020
    • George Kiagiadakis's avatar
      lib: refactor WpProxy · 2f3f5f8e
      George Kiagiadakis authored
      This is an attempt to unclutter the API of WpProxy and
      split functionality into smaller pieces, making it easier
      to work with.
      
      In this new class layout, we have the following classes:
      
      - WpObject: base class for everything; handles activating
      |           and deactivating "features"
      |- WpProxy: base class for anything that wraps a pw_proxy;
       |          handles events from pw_proxy and nothing more
       |- WpGlobalProxy: handles integration with the registry
      
      All the other classes derive from WpGlobalProxy. The reason
      for separating WpGlobalProxy from WpProxy, though, is that
      classes such as WpImplNode / WpSpaDevice can also derive from
      WpProxy now, without interfacing with the registry.
      
      All objects that come with an "info" structure and have properties
      and/or params also implement the WpPipewireObject interface. This
      provides the API to query properties and get/set params. Essentially,
      this is implemented by all classes except WpMetadata (pw_metadata
      does not have info)
      
      This interface is implemented on each object separately, using
      a private "mixin", which is a set of vfunc implementations and helper
      functions (and macros) to facilitate the implementation of this interface.
      
      A notable difference to the old WpProxy is that now features can be
      deactivated, so it is possible to enable something and later disable
      it again.
      
      This commit disables modules, tests, tools, etc, to avoid growing the
      patch more, while ensuring that the project compiles.
      2f3f5f8e
    • George Kiagiadakis's avatar
  4. Jun 04, 2020
  5. May 29, 2020
    • George Kiagiadakis's avatar
      props: refactor WpSpaProps into WpProps · 9ae70711
      George Kiagiadakis authored
      - make it a GObject so that it can emit its own signals
      and so that it can be shared between multiple proxies
      - share the WpProps instance between endpoints, endpoint-streams
      and their underlying nodes
      - introduce the concept of the caching mode that redirects _set
      to _set_param of the proxy that actually has the props; this allows
      shared WpProps to actually set changes on the correct proxy
      in a transparent way
      - change methods to consume the ref of the pod and reflect that
      also on wp_proxy_set_prop()
      - refactor the export process on endpoints & endpoint-streams
      so that they always get all the required features (info, props, bound)
      and make it async so that we can take time to prepare the underlying
      node to have FEATURE_PROPS
      - update the props & endpoint unit tests, bringing back all the
      checks that the endpoint unit test used to have
      9ae70711
  6. May 03, 2020
  7. Apr 21, 2020
  8. Apr 14, 2020
  9. Apr 13, 2020
  10. Apr 09, 2020
  11. Apr 07, 2020
  12. Mar 31, 2020
  13. Mar 29, 2020
  14. Feb 17, 2020
  15. Feb 14, 2020
    • George Kiagiadakis's avatar
      registry: safely destroy proxy when its initial augment is still in progress · 813351bc
      George Kiagiadakis authored
      ... in case the global is removed from the registry before
      the initial augment completes
      813351bc
    • George Kiagiadakis's avatar
      registry: use a temporary globals list · 269b9e19
      George Kiagiadakis authored
      When a new global is created, it is not certain
      if the registry global event or the proxy bound event will
      be fired first. In order to make sure we associate all
      proxies to their WpGlobals correctly, we now wait a core sync
      before exposing globals to the object managers, so that in case
      the implementation proxy receives the bound event after the
      registry creates the WpGlobal, we can make sure to use this
      proxy instead of constructing a new one through the object managers
      269b9e19
    • George Kiagiadakis's avatar
      object-manager: refactor to be able to track locally created proxies · 753e7085
      George Kiagiadakis authored
      There are 3 kinds of WpProxy objects:
       * the ones that are created as a result of binding a global
         from the registry
       * the ones that are created as a result of calling into a remote
         factory (wp_node_new_from_factory, etc...)
       * the ones that are a local implementation of an object
         (WpImplNode, etc...) and are exported
      
      Previously the object manager was only able to track the first kind.
      With these changes we can now also have globals associated with
      WpProxies that were created earlier (and caused the creation of the global).
      This saves some resources and reduces round-trips (in case client
      code wants to change properties of an object that is locally
      implemented, it shouldn't need to do a round-trip through the server)
      753e7085
  16. Feb 12, 2020
  17. Feb 11, 2020
    • George Kiagiadakis's avatar
      proxy/core: refactor object creation · 9330208a
      George Kiagiadakis authored
      * core no longer exposes create_remote/local_object
      * node, device & link have constructor methods
        to enable the create_remote_object functionality
      * added WpImplNode to wrap pw_impl_node and allow creating
        "local" node instances
      * added WpSpaDevice to wrap spa_device and allow creating
        "local" device instances
      * exporting objects in all cases now happens by requesting
        FEATURE_BOUND from the proxy, eliminating the need for WpExported
      * replaced WpMonitor by new, simpler code directly in module-monitor
      * the proxy type lookup table in WpProxy is gone, we now
        use a field on the class structure of every WpProxy subclass
        and iterate through all the class structures instead; this is
        more flexible and extensible
      9330208a
  18. Jan 22, 2020
  19. Jan 13, 2020
  20. Jan 10, 2020
  21. Dec 04, 2019
  22. Dec 03, 2019
  23. Nov 13, 2019
    • George Kiagiadakis's avatar
      lib: introduce WpObjectManager · e7e5c668
      George Kiagiadakis authored
      * rework how global objects are stored in the core
      * rework how users get notified about global objects
        and proxies of remote global objects
      
      The purpose of this change is to have a class that can manage
      objects that are registered in the core or signalled through the
      registry. This object can declare interest on certain types
      of global objects and only keep & signal those objects that it is
      interested in. Additionally, it can prepare proxy features and
      asynchronously deliver an 'objects-changed' signal, which is
      basically telling us that the list of objects has changed.
      
      This is useful to simplify port proxies management in WpAudioStream.
      Now the stream object can declare that it is interested in ports
      that have "node.id" == X and the object manager will only maintain
      a list of those. Additionally, it will emit the 'objects-changed'
      signal when the list of ports is complete, so there is no reason to
      do complex operations and core syncs in the WpAudioStream class
      in order to figure out when the list of ports is ready.
      
      As a side effect, this also reduces resource management. Now we
      don't construct a WpProxy for every global that pipewire reports;
      we only construct proxies when there is interest in them!
      
      Another interesting side effect is that we can now register an
      object manager at any point in time and get immediately notified
      about remote globals that already exist. i.e. when you register
      an object manager that is interested in nodes, it will be immediately
      notified about all the existing nodes in the graph. This is useful
      to avoid race conditions between connecting the signal and objects
      beting created in pipewire
      e7e5c668
  24. Nov 07, 2019
Loading