Arnaud Ferraris authored 3 years ago and Detlev Casanova committed 3 years ago

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

Arnaud Ferraris authored 3 years ago and Detlev Casanova committed 3 years ago

In order to facilitate license compliance, the dashboard should report
the most severe license issues found in packages from the "target"
repository: this includes cases where we override the existing license
information (especially when specifying a global default license) or
packages for which whitelisting is enabled for the whole source tree.

As part of this effort, this commit fetches the copyright override and
whitelisting files, and process those in order to detect major issues.
The corresponding new per-branch flags are then set accordingly and
added to the output file.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

Arnaud Ferraris authored 3 years ago and Detlev Casanova committed 3 years ago

The `filter_cache()` method used an optional `check_tags` argument to
decide between several code paths. This does not properly reflect the
purpose of this argument, which is to differentiate between 2 use cases:
- check and populate information about the descendants of a given ref
- check and populate component and license information

As additional fields will have to be taken into account in the future,
this rework aims at making the aforementioned method more flexible,
while making it clear to which use-case belongs each code path. To that
effect, the `check_flags` argument is renamed to `purpose` and now uses
an enum to distinguish between use-cases. It also only processes the
relevant data for the current use-case:
- when checking for descendants, only descendants data is looked up and
  updated
- when checking for license info, only this information is checked and
  updated

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

Now that v2023dev1 has been released do not complain about updates that
need to be landed to it.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

All the development happens on v2022 and the mirroring on the
Apertispro side is complete, so we can stop monitoring v2022pre.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

This avoids making unnecessary requests when branches and tags didn't
change since the last run.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

Reduce the severity of the logs about retrieved licensing logs since
they are currently drowning everything else.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Retrieve all descendants to correctly detect when a branch got merged in
another and which tags apply.

Unfortunately `commit.refs()` does not currently handle pagination, so
only the first 20 items were downloaded.

This meant that in some cases no tags were returned, so no version could
be computed. In other cases this may have cause incorrect reports of
branches not being merged into their downstream, or other issues due to
computing the wrong version for the branch.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Fix the typing class path, it's `collections.abc.Sequence`.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Emanuele Aina authored 3 years ago and Vignesh Raman committed 3 years ago

When retrieving the files under `debian/apertis` only expect the
404 Not Found error and re-raise everything else: we want to cleanly
handle missing files, but timeouts (for instance) are actual errors.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

We should report an error on the package if it missing the
`debian/apertis/component` file rather than crashing badly.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Emanuele Aina authored 3 years ago and Vignesh Raman committed 3 years ago

Applying filters one-at-a-time can lead do broken behavior:

* deselect both the `info` and `error` severity checkboxes
* all reports are correctly hidden
* deselect the `apertis/v2021` channels checkbox
* all the other reports incorrectly show up again, regardless of
  their severity

This is because when applying the updated channels filter the code does
not look at the other active filters.

Tweak the code to always check *all* filters regardless of the one that
has been updated.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Nowe that we have a single list of components, drop the
`_NONFREE` suffix.

No functional changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

With v2020 reaching its end-of-support there's no need to keep around
the list of component without `non-free`, which was introduced in v2021.

No functional changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

When getting an exception, ensure the current package name is printed to
debug which one has faulty data.

For instance this is now the output, previously only the first exception
was printed:

    Traceback (most recent call last):
      File "./bin/packaging-check-invariants", line 586, in <module>
        checker.check_missing_license_report(package)
      File "./bin/packaging-check-invariants", line 533, in check_missing_license_report
        if branch.component == "target" and not branch.license_report:
      File "./bin/packaging-check-invariants", line 90, in __getattr__
        item = super(DictWrapper, self).__getitem__(attr)
    KeyError: 'component'

    The above exception was the direct cause of the following exception:

    Traceback (most recent call last):
      File "./bin/packaging-check-invariants", line 588, in <module>
        raise Error(package.name) from e
    __main__.Error: aalib

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Get rid of an indentation level by moving the iteration over the
packages out of the check functions.

This also will make improving error reporting easier since the package
context of each check is now clearly defined when calling it.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Point to the GitLab compare tool when a branch is lagging behind the
others, to let people find easily the missing commits and potentially
create a merge request for them using the handy button in the comparison
page itself.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

When we release a channel like `apertis/v2023dev0` we still want to keep
it monitored for errors to catch issues that may impact downstreams when
they mirror it, but we do not want to hear complaints about packages
missing updates and lagging behind as that's on purpose.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Rather than iterating over a list and check for membership in another
list, just iterate on the other list since we already know it is a
strict subset.

No behavioral changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Avoid assigning two different things to the same variable by giving a
more descriptive name to the second one and add a comment.

No behavioral changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Create a new method to reduce the nesting of the code.

No behavioral changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Reduce nesting using an early `continue`.

No behavioral changes.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

The job retrieving data from OBS often reaches the default 1h timeout,
so let's be more lenient.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

For some of the longer running jobs it is sufficient for the service
they interface with to be marginally slower than usual to trigger a
timeout, either in the overall job execution time on on specific
requests from the tools, causing the whole pipeline to fail.

In those case we can afford to retry the job to see if things improve.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Listing which e.g. `debian/*` tag is contained in a `apertis/*` branch
is rather pointless and is a significant waste of resources.

Limit the reported tags to the one with a matching prefix, so only
`debian/*` tags are listed on `debian/*` branches and only `apertis/*`
tags are listed on `apertis/*` branches.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Since we already list all the tag contained in each branch, including
the symmetrical list of descendant branches for each tag in the YAML is
wasting bytes with duplicated information.

We still use the list of descendant branches internally to compute which
tags are contained in each branch.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Let's save a few bytes by getting rid of some pointless information.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

This saves a few bytes for each `debian/*` and `upstream/*` branch.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Emanuele Aina authored 3 years ago and Ryan Gonzalez committed 3 years ago

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Emanuele Aina authored 3 years ago and Walter Lozano committed 3 years ago

The `./localtest` script was skipping the `lint` job, not the `lint`
stage, so when I added the job to exercise `./localtest` itself during
the `lint` stage I have caused `./localtest` to appear in its own
output, which means that if you pipe it into a shell it will call
itself. Luckily recursion will stop there and this is about not doing
something pointless rather than actually fixing something broken.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Highlight the `Filter` button when any filter is active and reports may
be hidden.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Rather than using plaintext error messages, use readable codes and
structured metadata for errors and updates to make them easier
to process.

This will be particularly useful for filtering: for instance we
preserve the branch information rather than muddling it in the
error message.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

When multiple sources are published, check the version of the
most recent one rather than whatever comes first.

This avoids reporting a mismatched version when things are just
ambiguous.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>