Add a symlink in the python 3 system path to maek apertis_tests_lib
available to the system.

Note that this is a somewhat ugly solution. To solve it properly the
build system needs to be a bit revamped to install the python libraries
(and really binaries) in the right spots in the system.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2201

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

This is effectively a complete rewrite of the tests. Some of the common
functionality has been split out to apertis_tests_lib. The external
interfaces and behaviour of the tests should have remained unchanged.

The tests needed to change considerably in structure because of the
difference between how BlueZ 4 and BlueZ 5 handle device objects. BlueZ
4 only creates a device object if an adapter is paired with that device.
BlueZ 5 creates it as soon as a device is discovered.

Apart from that, the main differences between the two APIs are in the
shift to standard D-Bus interfaces (Properties and ObjectManager) in
BlueZ 5.

While rewriting the tests, a lot of multi-second sleep() calls have been
removed in favour of waiting for the relevant completion signals from
the D-Bus API. This means some potentially unbounded waits if the
Bluetooth daemon misbehaves or ends up in a state the unit test does not
expect. But otherwise it means faster test execution and no failures due
to races between the sleep() and the Bluetooth daemon completing an
operation.

[ Small updates for review  comments ]

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D971

Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2194

Of the schedulers we compile, only cfq supports the block I/O weighting
feature that is exercised by test_blkio_weights_random_read and
test_blkio_weights_sequential_read.

Related to <https://bugs.apertis.org/show_bug.cgi?id=635

>

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2165

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2164

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2163

Leave a symlink behind for compatibility.

The test still has a dependency on chaiwala-tests for now, so that it
can be run against older versions of apertis-tests.

While I'm editing dependencies, add python, since the test runs it
explicitly.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2162

This makes it much easier to try new versions.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2161

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Simon McVittie authored 9 years ago and Sjoerd Simons committed 9 years ago

These are ostensibly JSON, but what they actually are is Jinja
templates whose *output* is JSON. In particular, they can contain
{# comments in this syntax #}, causing syntax-check to fail.

lqa will check that their output is valid JSON anyway, so I think
the ability to have comments is worth more than the syntax check.

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2156

Mathieu Duponchelle authored 9 years ago and Sjoerd Simons committed 9 years ago

We no longer ship chaiwala-btrfs.

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2158

Mathieu Duponchelle authored 9 years ago and Sjoerd Simons committed 9 years ago

mc-tool (among other things), wasn't installed on the LAVA instance.

This package is provided by telepathy-mission-control-5 , which
is correctly listed here:

https://wiki.apertis.org/QA/Test_Cases/apparmor-folks



As such, this commit adds it, and other dependencies listed on
the wiki, but absent in the yaml file.

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2132

Emilio Pozuelo Monfort authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2131

Simon McVittie authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2117

Simon McVittie authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2116

Mathieu Duponchelle authored 9 years ago and Sjoerd Simons committed 9 years ago

And check the id could actually be looked up.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2115

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commit removes the {{arch}} variable from the image
names in the job template files.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commit removes the changes of an optional board
and image type for the minimal template.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

Added the following attributes to the job templates: image.date,
image.version, image.board and image.type.

These attributes can be used to filter LAVA tests results based
on their values.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commit reverts a previous change about testing for an optional
image type and board to work around the target wayland image url not
matching the image name. The issue is now properly fixed in the image
generation scripts.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commit changes the template-dir variable to the relative path
apertis-tests/templates/ , so the templates files can be found from
the same directory this repository is checked out.

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commit updates all the test templates and profiles for the new
images urls. It includes the following changes:

- Add two new optional variables opt_image_type/opt_board and check
if they are defined before using them as a work-around for the amd64
wayland image url.
- Move some common profiles variables to the parent profile.
- Include the new minnowboard-max-minimal profile.

Xavier Claessens authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1309

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

This commits adds the package dependency 'telepathy-mission-control-5'
for the telepathy-ring test.

Luis Araujo authored 9 years ago and Sjoerd Simons committed 9 years ago

Folks packages were dropped from the images by default so now the tests
need to explicitly install these packages as dependencies.

Jonny Lamb authored 9 years ago and Sjoerd Simons committed 9 years ago

On fast platforms (amd64) these fail with a "Conflicting UIDs found in
added contacts" which is very weird, so add a few sleeps here which
ensure the tests pass.

Bug: https://bugs.apertis.org/show_bug.cgi?id=610



Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1304

Using an alpha value of 0 makes the stage transparent if the device
happens to have an ARGB visual on X (or always on wayland)

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Reviewed-by: Mathieu Duponchelle <meh@collabora.co.uk>

Differential Revision: https://phabricator.apertis.org/D1154

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

See the previous commit.

Bug: https://bugs.apertis.org/show_bug.cgi?id=602



Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1170

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

For the 3.18 kernel release, the vivi v4l test driver was dropped, and
replaced by the vivid driver. This does much the same thing, but has a
different set of options, and outputs at a different resolution by
default.

Update the v4l/automated/run-test.sh test to use vivid instead of vivi.

Bug: https://bugs.apertis.org/show_bug.cgi?id=602



Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1169

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

Otherwise the folks-ofonotest.sh file tries to set the libfolks backend
configuration to a non-existent file when the folks-ofono-backend test
is run, and folks-inspect ends up showing all contacts instead of just
contacts from the oFono backend.

Bug: https://bugs.apertis.org/show_bug.cgi?id=605



Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1164