Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

In order to test newer version before they land in the main branches
enable running tests on MR.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

AUM does not set the right refs to the repo commit when the upgrade
contains development and release entries in its ref-bindings, e.g. it will
use v2022dev3 instead of v2022 if both are present.

When adding ref-bindings to a commit, OSTree sort them in default
alphabetic order using strcmp().

This commit looks for the correct ref for the repo commit.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

On U-Boot platforms the default bootlimit is set in the bootloader
itself with `CONFIG_BOOTCOUNT_BOOTLIMIT=3` (see the
`apertis/imx6/0003-mx6sabrelite-enable-bootcount.patch` and
`apertis/renesas/0003-renesas-enable-bootcount.patch` patches), so let's
default to three failed boots before rollback here to have a more
consistent behavior across platforms.

This in particular affects the UEFI platforms (amd64).

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Sudarshan CP authored 3 years ago and Frederic Danis committed 3 years ago

Signed-off-by: Sudarshan C P <sudarshan.cp2@in.bosch.com>

Moses Christopher authored 4 years ago and Frederic Danis committed 3 years ago

New nvmem backend added to boot-state.
This backend supports update rollback mechanism for
TI AM335x's SOC or processor which has RTC scratch registers.
For boot-state mechanism RTC scratch_register2 fields used as below
 - byte zero hold boot count value
 - byte one hold the update available state
 - byte two hold the version
 - byte four hold boot count magic

Signed-off-by: Moses Christopher <BollavarapuMoses.Christopher@in.bosch.com>

Without udisks2 and libblockdev-crypto2 only online updates are
supported.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Fix the error below when invoking `gpb dch`:

    re.error: bad escape \T at position 38

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Previous commit 762c178b introduces an endless loop, preventing AUM to
run correctly on EFI systems.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

../managerd/boot-state-efi.c: In function ‘aum_boot_state_efi_read_dir’:
../managerd/boot-state-efi.c:78:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
   78 |   while (conf_file_name_ = g_dir_read_name(dir_name))
      |          ^~~~~~~~~~~~~~~
../managerd/boot-state-efi.c: In function ‘aum_boot_state_efi_conf_file_save’:
../managerd/boot-state-efi.c:126:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  126 |   while (conf_file_name = g_dir_read_name(dir_name))
      |          ^~~~~~~~~~~~~~
../managerd/boot-state-efi.c:145:1: warning: control reaches end of non-void function [-Wreturn-type]
  145 | }
      | ^

/usr/include/glib-2.0/glib/gmacros.h:1049:10: warning: ‘options’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1049 |     { if (_ptr) (cleanup) ((ParentName *) _ptr); }                                                              \
      |          ^
../managerd/main.c:382:24: note: ‘options’ was declared here
  382 |   g_autoptr (GVariant) options;
      |                        ^~~~~~~

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

AUM crashes when an update is done OTA or using a downloaded bundle, i.e.
not an encrypted bundle on an USB drive and so without a loopback set.

Check presence of a loopback before trying to remove it.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Moses Christopher authored 4 years ago and Frederic Danis committed 3 years ago

The following boot state backend's throw a critical message,
when the respective boot state backend is not selected
  - boot-state-uboot-env
  - boot-state-uboot-ext
  - boot-state-efi

Reduce the log level by using g_message instead of g_critical

Signed-off-by: Moses Christopher <BollavarapuMoses.Christopher@in.bosch.com>

Gireesh Hiremath authored 4 years ago and Frederic Danis committed 3 years ago

If target failed to unlock upgrade bundle file,
required to notice the error.

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Gireesh Hiremath authored 4 years ago and Frederic Danis committed 3 years ago

Avoid mass storage getting busy, even after bundle update.
we have to close the mounted loop device.

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Gireesh Hiremath authored 4 years ago and Frederic Danis committed 3 years ago

To show update progress to user when it starts decrypting the bundle file

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Gireesh Hiremath authored 4 years ago and Frederic Danis committed 3 years ago

Deploying state for offline upgrade. While updating bundle
file in offline, noticed that SystemUpgradeState follow
state Checking -> Pending then reboot the device.
There is the missing of state deploying and same is added

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Added optional parameter for changing network updates polling time:
  updatectl --check-network-updates 3600

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Added property `UpdatesPollingTime` for delay between OTA upgrades
attempts in seconds. Default is 300 seconds.
Could be set configuration file as well:
 [Manager]
 UpdatesPollingTime=300

Changing the property is not starting the update itself but reset the
timer to new value if update has been enabled already.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

If the `--dry-run` is used for offline upgrade, the static delta
will pass over all checks but upgrade will not started.

The output from `updatectl` started in monitoring mode will contain:
 AUM-Message: 15:32:30.993: Upgrade status: Available

and the log of AUM:
 Feb 21 15:32:57 apertis apertis-update-[1098]: Static delta is applicable for the system

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Now it is logging the downloading progress correctly instead of keeping
silence about the progress:
 Feb 21 13:01:56 apertis apertis-update-managerd[688]: Receiving metadata objects: 13/(estimating) 1.1 MB/s 2.1 MB
 Feb 21 13:01:57 apertis apertis-update-managerd[688]: Receiving metadata objects: 38/(estimating) 5.8 MB/s 17.3 MB
 Feb 21 13:01:59 apertis apertis-update-managerd[688]: Receiving objects: 29% (128/431) 5.9 MB/s 29.7 MB
 Feb 21 13:02:00 apertis apertis-update-managerd[688]: Receiving objects: 43% (186/431) 6.2 MB/s 37.1 MB
 Feb 21 13:02:01 apertis apertis-update-managerd[688]: Receiving objects: 58% (251/431) 5.7 MB/s 39.6 MB
 Feb 21 13:02:02 apertis apertis-update-managerd[688]: Receiving objects: 66% (286/431) 5.1 MB/s 40.4 MB
 Feb 21 13:02:04 apertis apertis-update-managerd[688]: Receiving objects: 92% (397/431) 4.3 MB/s 42.9 MB
 Feb 21 13:02:04 apertis apertis-update-managerd[688]: libostree pull from 'origin' for apertis/v2022dev1/amd64-uefi/minimal complete
                                                       security: GPG: disabled
                                                       security: SIGN: commit http: TLS
                                                       non-delta: meta: 70 content: 361
                                                       transfer: secs: 11 size: 43.3 MB

Use the `ostree_repo_pull_default_console_progress_changed` from
libostree instead of custom function `_ostree_upgrader_log_progress`,
since we do not need to set the downloading state in this function
anymore.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

If the dry run mode is set then just check is the OTA update is available
and do not try to download and apply the upgrade with:
  updatectl -u --dry-mode

The log from `updatectl` started in monitor mode will have new status:
 AUM-Message: 14:45:27.283: Upgrade status: Available

and the AUM log will contain the new string:
 Feb 21 14:45:27 apertis apertis-update-[888]: Network upgrade is available

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Option `--dry-run` should be used if we do not need to do an upgrade
but want to check if OTA upgrade is available or offline upgrade is
applicable for the current system.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

The dry run mode allows to check the availability and appliance of the
upgrade without the upgrade itself.
Additional state `AUM_OSTREE_UPGRADE_STATE_AVAILABLE` shows if the OTA update
is available and may be applied.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

When AUM crashes with an encrypted update bundle unlocked this will prevent
later update and the deletion of the loop device.
This commit clean-up the loop devices with an encrypted bundle backing
file.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>