More polkit-parsing.sh cleanup
- Sep 24, 2024
-
-
Dylan Aïssi authoredSigned-off-by:
Dylan Aïssi <dylan.aissi@collabora.com> -
Dylan Aïssi authored
This was used for debugging, but there is no real need in the cleanup function. So, let's reduce the noise in the log by not printing all commands from the cleanup(). Signed-off-by:Dylan Aïssi <dylan.aissi@collabora.com> -
Dylan Aïssi authored
For unknown reasons (race conditions?), pkaction randomly fails with: "Error enumerating actions: GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying" So, to mitigate this issue give it some more time to be ready, although this should be the aim of "gdbus wait" above. Signed-off-by:Dylan Aïssi <dylan.aissi@collabora.com> -
Dylan Aïssi authored
See https://salsa.debian.org/utopia-team/dbus/-/commit/e3a4c1aec4aa8eaedac0e1bddc383529c86b72c0 The interoperable cross-distro path is /var/run/dbus/system_bus_socket, so this remains the upstream default for the benefit of distributions where /var/run and /run are (problematically) not guaranteed to be equivalent. However, Debian Policy since at least v4.1.5 guarantees that /var/run is a symlink to /run, and this has been implemented for several stable releases (since at least initscripts 2.88dsf-29 in 2012, in the sysvinit case), so it is harmless to prefer the path in /run, which has advantages in a few corner cases (ability to unmount /var is the main one) and avoids warnings from systemd. Signed-off-by:
Dylan Aïssi <dylan.aissi@collabora.com> -
Dylan Aïssi authored
Usually, polkitd should already be killed in the body script. However, in case of an earlier failure (for instance at pkaction), the pkill step is not reached and then we need to kill it in the cleanup step. Drop "set -e" to detect other failures. Fix: 4ef7af4d. Signed-off-by:
Dylan Aïssi <dylan.aissi@collabora.com>
-