Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Use bold font for subcommands and options, italics for variables
and values.

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

A gdbserver may be running left over from a previous debug session.
It will still be listening on the TCP port, preventing a new instance
from starting, so we need to kill it.

However, if we allocate a PTY when spawning it, it will die once the
session ends.

For some reason, with get_pty=True, the gdbserver’s output is coming
from stdout, not stderr.

Apertis: T4463

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

The test-export script tests the `ade export` command.
It creates an install target in moc/Makefile.in and uses it to
simulate ade's export command, which further bundles the installed files
The script then unpacks the created bundle and verified the sample file
that was bundled through `ade export`

Currently, we do it the crude way to extract the file from the bundle
because ostree/flatpak doesn't have a cleaner implementation
For details, see: https://github.com/flatpak/flatpak/issues/126



Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>
Reviewed-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7914

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7435

When the debugger thread starts, it spawns a gdbserver and
waits forever. Use the Channel from paramiko to monitor the process
return value and quit when it's terminated.
Discard any output from gdbserver as it can stall the ssh link in extreme
cases.
Additionnaly "while True: pass" loops are busy loops. Relax those.
Do that for non-interactive ade too.

Apertis: https://phabricator.apertis.org/T4462



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7431

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7430

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>

sysroot tarball packs `./etc/image_version`, ade fails
to identify it as `etc/image_version`, therefore, we
need to append `./` to the file path.

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7384

Signed-off-by: Simon McVittie <smcv@collabora.com>

It is normal and expected for agent entry points to not have an icon.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6858

`ade configure` and `ade build` have `--native` option, but `install`
and `uninstall` commands doesn't. To install/uninstall a bundle which
is built with `--native`, user should use `ade install --simulator`
because two options actually do same thing.
For the consistency, the option, `--native`, is added.

Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Signed-off-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6807

Signed-off-by: Simon McVittie <smcv@collabora.com>

When unparsed arguments were picked out, they were appended
to args. This is problematic if the wrapped command takes
command-line options with values of the form "--foo bar" (as
opposed to --foo=bar), because they would be re-ordered to "bar --foo",
likely causing a syntax error. It is obviously also a problem if
order is significant for the wrapped command. Prepend the unparsed
arguments to args instead of appending.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6798

Picking out the known arguments and leaving unknown arguments is
dangerous, because typos and prefix-matching can have unintended
results. To discourage this, warn if any unknown arguments were
found. These are all considered correct, and are equivalent
(except for order):

    ade configure --native -- VARIABLE=1 --with-option
    ade configure --native VARIABLE=1 --with-option
    ade configure --native -- --with-option VARIABLE=1

but this will now provoke a warning for --with-option:

    ade configure --native --with-option VARIABLE=1

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6797

The common convention of passing "--" as a separator between
arguments for this command and arguments for the wrapped command
did not work, because it would also pass the "--" through. For
instance, "ade configure --native -- --device=foo" should pass
"--device=foo" to the configure script instead of interpreting it
as ade's own --device option.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6796

Subcommands with no REMAINING arguments, such as "ade uninstall",
would previously accept and ignore unknown arguments. This could be
very bad if the command is something like "ade uninstall --dry-run".

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6795

Because we set args to a new value, any arguments passed to
"ade configure" were ignored.

Apertis: https://phabricator.apertis.org/T3978



Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6774

Python arguments are passed by reference, so if we append to these
arrays, the caller's copy of the list is modified. This seems unlikely
to be intended.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6773

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Simon McVittie <smcv@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6742

Currently the sysroot file is named 'sysroot'. This prevents to have
different latests sysroot for different architectures. For example, ade
sysroot latest --arch arm64 returns the url of the armhf sysroot if it
was the last sysroot uploaded.
A symbolic link called sysroot can be used so that older version of
ade are still able to download a sysroot file.

Apertis: https://phabricator.apertis.org/T3849



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Simon McVittie <smcv@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6678

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6426

The current test infrastruture only exercises "ade sysroot".
This test add support to exercise "ade configure" using a mock project
implementation that lures "ade configure" as if a real project was
being configured.
This is done because the test sysroots do not have real autotools.

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6413

The handler is already present since the info and sysroot subcommand
are already having a --path parameter.

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6412

Create this dummy project to exercise ade configure and build.
autogen.sh and configure are mocking the real scripts behavior.
It is also possible to build from a build directory.

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6411

The sysroot tag parser was not tested and a regression occured
To catch future regressions make use for ade info and check
that the expected sysroot info can be read during tests.
Add support for --path to the ade info subcommand parser work
in temporary test directory.

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6390

Currently test_util.py can only test 'ade sysroot'. Additionnaly
it uses about 3 different python syntaxes for parameters. *args
is used for the majority of parameters, path and config are passed as
**kwargs. Finally command, is a positionnal argument.

In order for ade functions other than sysroot can thus be tested,
simplify run_cmd api so that in only take (*args) wth direct arguments.
This means changing all the should_succeed and should_fail calls so
that they no longer assume 'sysroot' is the command to be tested.

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6410

That error was not defined and triggered an Exception in the Exception.
It was not raised either. Use SysrootManagerError instead

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6402

Recent parsing changes introduced this regression.

Apertis: https://phabricator.apertis.org/T3777



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6383

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6320

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6265

The current parsing expressions assume release is in the form of
YY.QQ e.g. 16.09. While this is true for Apertis, it's not mandatory for
derivatives so drop that assumption.

While fixing that, move to using match names to make the regexps a bit
more foolproof.

Also split up the function parsing the string from a version file
(/etc/image_version) and from the sysroot version tag as they are
fundamentally different, the current regexp handled both in extremely
subtle and error-prone ways.

Apertis: https://phabricator.apertis.org/T3555



Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6264

The SysrootVersion class was trying to define a date and build index
from the build identifier. While this is true by convention for the
Apertis builds, this may break in the future.

Instead treat the build identifier as an opaque string consisting of just
digits and dots.

While there, also make all SysrootVersion arguments optional to improve
readability and rename author to variant (which is its intended
meaning).

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6263

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6205

sudo is used to run ribchesterctl to install a bundle on the target,
but it is not used to run ribchesterctl to install a bundle on the
simulator. Let's change that.

Change a call to ribchesterctl instead of ribchester on the fly.

Apertis: https://phabricator.apertis.org/T3556



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6200

We suppose the intent from the user when configuring an existing
directory is to rebuild all the binaries for the new configuration. For
example, the user could have changed the sysroot.

Apertis: https://phabricator.apertis.org/T3557



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6141

In order to configure different target and build in a different
directory, the build-dir parameter will run configure from a
subdirectory of the root. This allows separating build artifacts
from source code. It allows to build for different targets
at the same time.
Also add support for this in export, run, debug, install, and
uninstall commands.
Do not add it in info command yet.

Apertis: https://phabricator.apertis.org/T3557



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6129