Skip to content
Snippets Groups Projects
Commit 687796e2 authored by Dylan Aïssi's avatar Dylan Aïssi
Browse files

apertis-abi-compare: fix sporadic issue with std headers

Due to a bug in abi-compliance-checker, std headers are occasionally
used for analyzing leading to wrongly detect an ABI breakage.
We globally exclude them to avoid this noise until it is fixed in ACC.

See: https://github.com/lvc/abi-compliance-checker/issues/85



Signed-off-by: default avatarDylan Aïssi <dylan.aissi@collabora.com>
parent 4fa2faf3
No related branches found
No related tags found
3 merge requests!44Merge changes from apertis/v2022-updates into apertis/v2022,!43Backport v2022-updates <- v2023pre: Improvement ABI checker script,!41apertis-abi-compare: Improve the final output with a summary
This commit is part of merge request !41. Comments created here will be created in the context of that merge request.
......@@ -4,6 +4,7 @@ all clean install:
$(MAKE) -C tests $@
$(MAKE) -C tools $@
$(MAKE) -C cmake $@
$(MAKE) -C aac $@
check: all
$(MAKE) -C tests check
......
aac/Makefile 0 → 100644
INSTALL ?= install
PREFIX ?= /usr
aacdir = $(PREFIX)/share/apertis-abi-compare/
AAC_CONFDIR ?= $(DESTDIR)$(aacdir)
AAC_CONF = \
aac-skip-headers.conf
all:
clean:
install:
$(INSTALL) -d $(AAC_CONFDIR)
for t in $(AAC_CONF); \
do \
$(INSTALL) $$t $(AAC_CONFDIR); \
done
stdio.h
stdlib.h
string.h
ctype.h
......@@ -2,3 +2,4 @@ usr/bin/
usr/share/man
etc/xdg/ade/sysroot.conf
usr/lib/cmake/
usr/share/apertis-abi-compare/
......@@ -166,6 +166,11 @@ def run_abi_checker(lib, xml_old, ver_old, xml_new, ver_new, arch):
acc_cmd.extend(['--arch', arch, '-lib', lib,
'-old', xml_old, '-v1', ver_old,
'-new', xml_new, '-v2', ver_new])
# Due to a bug in abi-compliance-checker, std headers are sporadically
# used for analyzing leading to wrongly detect an ABI breakage.
# We globally exclude them to avoid this noise until it is fixed in ACC.
# https://github.com/lvc/abi-compliance-checker/issues/85
acc_cmd.extend(['--skip-headers=/usr/share/apertis-abi-compare/aac-skip-headers.conf'])
acc_process = subprocess.run(acc_cmd)
sys.stdout.flush()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment