Adding Wi-Fi AP testcases to Apertis
Merge request reports
Activity
requested review from @fdanis
assigned to @sagar
mentioned in merge request !342 (closed)
requested review from @adalessandro and removed review request for @fdanis
re-assigning it to @adalessandro as suggested by @em
added 1 commit
- aec23562 - Incorporated Tino's comments and feedback for the Wi-Fi AP testcases
@sagar I don't have much context, so I'll be doing (perhaps) silly questions:
- Targets are limited to
[ armhf, amd64 ], whyarm64is not included?
- Targets are limited to
added 2 commits
marked this merge request as draft from 217a461b
- Resolved by Benani Sagar Kishore
@sagar please check commit !343 (0f282bf9) , we can squash it if you think it's fine.
- Instead of relying on
connmanto enable the interface, I'm just disabling it and then usingrfkill. - Fixed ocurrences of
wlan0bywifi_interface_name. - Removed unneeded network names and just kept the created one.
- Some other style changes.
Let me know what you think and let's squash it if it LGTYou.
- Instead of relying on
- Last reply by Benani Sagar Kishore
-
@sagar One question:
AFAIU, we have two sets of tests. The following test the different security protocols:
test-cases/wifi-wpa2-psk-accesspoint-setup.yaml test-cases/wifi-wpa3-sae-accesspoint-setup.yaml test-cases/wifi-wpa3-transition-mode-accesspoint-setup.yamlThe following rely on running one of the previous tests and then testing different situations (e.g. reboot):
test-cases/wifi-accesspoint-deactivation.yaml test-cases/wifi-accesspoint-reboot.yaml test-cases/wifi-accesspoint-uncontrolled-shutdown-reboot.yamlOn every test, SDK is always the station and the target device is always the AP, except for
test-cases/wifi-accesspoint-uncontrolled-shutdown-reboot.yaml.- Can use the same setup (SDK as station and target as AP)?
I think these tests are repeating the same content, so it might be worth just letting the second set to say: "run wifi wpa2 test and then run these steps to reboot/shutdown/disable".
Let me know what you think, I can push the changes if you want :-)
-
@adalessandro the below testcases are based on the suggestion by @Tino.Lippold-ext
- test-cases/wifi-accesspoint-reboot.yaml - test-cases/wifi-accesspoint-uncontrolled-shutdown-reboot.yamlplease see his comments too
` test-cases/wifi-accesspoint-deactivation.yamlplease retain the above testcases
With regard to your comment
Can use the same setup (SDK as station and target as AP)?I added 2 tests to show that both the SDK and Target can be used in either AP or Station mode. The user will be clear that either can be used to set up an AP/Station.
wifi-accesspoint-reboothere the wi-fi access point is created on the SDKwifi-accesspoint-uncontrolled-shutdown-reboothere the access point is created on the target -
@sagar , I just pushed the modifications as we talked. Could you check if this final version addresses the desired setup for these tests?
added 1 commit
- d9fdfc49 - Incorporated suggestions by Emanuele to run the tests only on OSTree ARMHF images
- Resolved by Ariel D'Alessandro
@adalessandro can i go ahead and merge ?
- Last reply by Benani Sagar Kishore
added 1 commit
- 771b9065 - test-cases: wifi: Remove packaage apt installtion
-
I have removed apt packages preconditions as we're now using ostree only, which will have hostapd and rfkill pkgs installed. See commit !343 (771b9065)
