Skip to content
Snippets Groups Projects

v2019 ← v2020: Backport sdk-vb-fullscreen fixes

Merged Benani Sagar Kishore requested to merge wip/sdk_vb_fullscreen/v2019 into apertis/v2019
All threads resolved!

Backport 69a8640f "Use MiniBrowser and WebGL to test rendering " and 40cda23e "updated the virtualbox version to be used" to v2019.

Task: T7308

Edited by Emanuele Aina

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Emanuele Aina changed target branch from apertis/v2022dev1 to apertis/v2019

    changed target branch from apertis/v2022dev1 to apertis/v2019

  • can the changes be merged if the changes are acceptable? Thank you.

    • Resolved by Emanuele Aina

      Thank you @sagar!

      Can you please tweak the commit message to be more descriptive?

      In general, assume that people are offline when reading your commit message and you can't rely on them reading some links to figure out what this commit is about. The links are useful to give people extra context, but all the important information should be in the commit message itself.

      In this case, this is a backport of 69a8640f and partially of 40cda23e so you should also mention that.

      Edited by Emanuele Aina
  • Benani Sagar Kishore resolved all threads

    resolved all threads

  • added 2 commits

    • fe274597 - This patch is submitted to address the steps required to execute the...
    • e239f73c - Merge branch 'wip/sdk_vb_fullscreen/v2019' of...

    Compare with previous version

  • Emanuele Aina added 2 commits

    added 2 commits

    • 66f945fc - sdk-vb-fullscreen: Use MiniBrowser and WebGL to test rendering
    • c6977798 - updated the virtualbox version to be used

    Compare with previous version

  • Emanuele Aina resolved all threads

    resolved all threads

  • The commits became a bit messy so I started clean.

    Since this was ultimately about backporting two existing commits to an older branch, I did that in the most straightforward way possible. Here's what I did:

    git checkout -b test-cases/sdk-vb-fullscreen.yaml origin/apertis/v2019
    git cherry-pick 69a8640ff72b
    vim test-cases/sdk-vb-fullscreen.yaml # fix the branch name in test-cases/sdk-vb-fullscreen.yaml
    git add test-cases/sdk-vb-fullscreen.yaml
    git amend
    git cherry-pick 40cda23e4a0c
  • Emanuele Aina changed title from Wip/sdk vb fullscreen/v2019 to v2019 ← v2020: Backport sdk-vb-fullscreen fixes

    changed title from Wip/sdk vb fullscreen/v2019 to v2019 ← v2020: Backport sdk-vb-fullscreen fixes

  • Emanuele Aina changed the description

    changed the description

  • merged

Please register or sign in to reply
Loading