Skip to content
Snippets Groups Projects
  1. Oct 14, 2019
    • George Kiagiadakis's avatar
      monitor & softdsp: fix alsa property names and api string · 5de6364a
      George Kiagiadakis authored
      The alsa.pcm devices currently use "device.api" = "alsa:pcm"
      but then the node overrides this later to just "alsa", which
      is confusing. For now, let's match "alsa:pcm" in the monitor,
      even though this does not appear on the node later.
      
      This commit fixes device preferences in wireplumber.conf,
      which were broken because the alsa endpoint names were empty
      of info about the alsa device
      5de6364a
  2. Oct 07, 2019
  3. Oct 02, 2019
    • George Kiagiadakis's avatar
      softdsp-endpoint/stream: remove the port proxies when they are removed on the server · 2e0e144f
      George Kiagiadakis authored
      When the audioconvert starts, it emits 2 ports, but when we set the PortConfig,
      it removes them and re-creates them. Previously, the stream class would not
      remove the old port proxies from the list and therefore they existed twice.
      
      It is also necessary here to store the proxies earlier, when they are added,
      instead of when they are augmented, so that we can ensure they are removed.
      Previously we would hit an issue where:
       - port proxy is added, augmented
       - augment completes but the GTask wants to complete asynchronously:
         it stores a ref on the proxy and adds an idle source
       - server removes the proxy, we delete it from the core's list
       - the GTask now calls the augment callback, which stores the (removed)
         proxy on the stream's port_proxies list...
      2e0e144f
    • George Kiagiadakis's avatar
      sofdsp-endpoint: run audioconvert in merge+split mode and use a new linking algorithm · f360aed9
      George Kiagiadakis authored
      Running audioconvert in merge+split mode is the only way to make this work with
      the adapter, since the adapter does not support passing multiple channels on
      a single port right now, and if it does at some point, it will be without a
      mixing node on the port, which means we will not be able to mix multiple
      audioconvert nodes on the same adapter. In the future we need to consider
      writing a lighter volume node with multiple channels support to replace
      audioconvert.
      
      The new linking algorithm now takes into account the channel positions and makes
      sure to link the correct channels together. Also, it avoids passing the port
      proxies inside the GVariants, thus making the algorithm a bit more generic
      and easier to unit test.
      f360aed9
  4. Sep 25, 2019
  5. Sep 22, 2019
    • George Kiagiadakis's avatar
      modules: fix reading proxy-node out GVariants · 50e52b9e
      George Kiagiadakis authored
      GVariant is instructed to store a 64-bit unsigned integer (mode "t")
      but we pass it a pointer to a pointer to read this value out,
      which will crash in 32-bit architectures, as the pointer doesn't have
      enough bits and g_variant_lookup therefore corrupts the stack.
      50e52b9e
  6. Sep 17, 2019
  7. Sep 07, 2019
  8. Sep 05, 2019
  9. Sep 02, 2019
  10. Aug 29, 2019
  11. Aug 28, 2019
  12. Aug 27, 2019
  13. Aug 26, 2019
  14. Aug 19, 2019
  15. Aug 15, 2019
  16. Aug 13, 2019
  17. Jul 30, 2019
  18. Jul 25, 2019
Loading