Skip to content

Revert commit related to PStore command patch update from upstream

Frederic Danis requested to merge wip/fdanis/6914 into apertis/v2021dev3

Fix the addition of PStore in mx6qsabrelite_defconfig, this has been removed by error in previous commit 50a74f57.

During tests on SabreLite board, I found that the memory isn't reserved for the Ramoops backend from parameters added in the Device Tree by U-boot, with the following message:

[    0.000000] OF: fdt: Reserved memory: unsupported node format, ignoring

This seems to be related to bad values for #address-cells and #size-cells, hard-coded to 2, see fdt_fixup_pstore() in cmd/pstore.c.
Afaict this should be set to the same value as for the Device Tree root (1 for this board) or retrieved using fdt_getprop_u32_default() (see fdt_pci_dma_ranges() in common/fdt_support.c of U-Boot), but with this value the kernel freeze during early boot.

This reverts commit f6c99fe2. This reverts commit 50a74f57.

Signed-off-by: Frédéric Danis frederic.danis@collabora.com

Edited by Frederic Danis

Merge request reports