Disable stdbuf

The stdbuf build process involves building a shared library externally and embedding it in the binary, which makes it difficult to extract debug info from binaries and then still strip them. This is pretty hard to fix while keeping coreutils cargo-installable, so just disable stdbuf instead.

https://phabricator.apertis.org/T10003

Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com

I think this should be split in two commits, one reverting the changes to build rust-coreutils twice, and a second one disabling stdbuf. Other than that, this look OK to me.

The MR should point to infrastructure/apertis-issues#431 (closed) as it is a public issue.

Probably it is worth to review the patches added to in

• 4c99a0d1
• 6305e130
• a44e74a0

I guess that some of those things are no longer needed.

Also, make sure that the metadata can be extracted with dwarf2sources, as probably using release profile already strips the symbols. In such a case, probably it is worth to add debug = true to the release profile.

requested review from @wlozano

assigned to @refi64

mentioned in issue infrastructure/apertis-issues#431 (closed)

added 2 commits

• 82e30eba - Disable stdbuf
• 5de92d5c - Stop building separate striped and non-stripped binaries

Compare with previous version

added 1 commit

• 6e36da21 - Enable debug symbols in release builds

Compare with previous version

resolved all threads

The idea behind the changes makes sense to me. However, I think that he rust-coreutils_bin2sources_amd64.json still does not provide all the information. For instance, I don't see many references to the source code in the project.

rust-coreutils_metadata_amd64.json

rust-coreutils_bin2sources_amd64.json

resolved all threads

added 1 commit

• 8e78f031 - Switch release builds back to thin LTO

Compare with previous version

added 1 commit

• 993db1dc - Refresh the automatically detected licensing information

Compare with previous version

This looks great, as @refi64 pointed the only drawback is the increment in the size by 1 MB, from 5.9 MB to 6.9 MB for amd64.

From my perspective, this should not be an issue, but let's confirm that with @sudarshan.

added 5 commits

• 956bb0ee - [1] Disable stdbuf
• 043aa31f - [2] Stop building separate striped and non-stripped binaries
• 229aa9b5 - [2] Enable debug symbols in release builds
• 92fa3dec - [2] Switch release builds back to thin LTO
• 0a190e44 - Release rust-coreutils 0.0.17-2+apertis11

Compare with previous version

resolved all threads

added 1 commit

• 0b16c6ce - Refresh the automatically detected licensing information

Compare with previous version

Which is the meaning of [1] and [2] in some commits? Are those references of some kind?

added 5 commits

• 61fab3c8 - Disable stdbuf
• 280b4e60 - Stop building separate striped and non-stripped binaries
• 49a2661c - Enable debug symbols in release builds
• c8a4582f - Switch release builds back to thin LTO
• 35fd2d28 - Release rust-coreutils 0.0.17-2+apertis11

Compare with previous version