-
- Downloads
librhosydd: Drop period parameters from rsd_subscription_new_wildcard()
It does not make sense for a wildcard subscription to restrict its signal emissions by period — a period criterion can only apply to a single attribute, otherwise we can end up with pathological cases where one attribute is emitted often enough to cause rate limiting; and all other attributes are emitted rarely enough to be accidentally dropped on one of the attribute emissions which is rate limited. RsdSubscription is not set up to allow the emission rates for each attribute to be tracked individually, which is what’s needed to implement period criteria for wildcard attributes properly. Instead, acknowledge that if the client has chosen to use a wildcard, they aren’t particularly fussy about what attributes they receive, and just give them everything, with no period limiting. Reviewed-by:Simon McVittie <simon.mcvittie@collabora.co.uk> Signed-off-by:
Philip Withnall <philip.withnall@collabora.co.uk> Differential Revision: https://phabricator.apertis.org/D3509
Showing
- clients/rhosydd-client.c 1 addition, 1 deletionclients/rhosydd-client.c
- libcroesor/tests/subscription-manager.c 1 addition, 2 deletionslibcroesor/tests/subscription-manager.c
- librhosydd/subscription.c 13 additions, 15 deletionslibrhosydd/subscription.c
- librhosydd/subscription.h 1 addition, 2 deletionslibrhosydd/subscription.h
- tests/integration.py 1 addition, 1 deletiontests/integration.py
Loading
Please register or sign in to comment