split('\n') communicate()'s stdout

debpython/pydist.py

@@ -118,8 +118,7 @@ def guess_dependency(req, version=None):
                  'or your upstream author to fix requires.txt')
         return set()  # should we sys.exit(1) here?
     req_dict = req_dict.groupdict()
-    name = req_dict['name'].lower()
-    details = data.get(name)
+    details = data.get(req_dict['name'].lower())
     if details:
         for item in details:
             if version not in item.get('versions', version):
@@ -157,7 +156,9 @@ def guess_dependency(req, version=None):
         exit(8)
 
     result = set()
-    for line in stdout:
+    for line in stdout.split('\n'):
+        if not line.strip():
+            continue
         result.add(line.split(':')[0])
     if len(result) > 1:
         log.error('more than one package name found for %s dist', name)

pyclean

@@ -91,8 +91,7 @@ def get_package_files(package_name):
     if process.returncode != 0:
         log.error('cannot get content of %s', package_name)
         sys.exit(2)
-    for line in stdout:
-        line = line.strip('\n')
+    for line in stdout.split('\n'):
         if line.endswith('.py'):
             yield line
 

pycompile

@@ -26,8 +26,8 @@ from __future__ import with_statement
 import logging
 import optparse
 import sys
-from os import environ, listdir, mkdir, walk
-from os.path import abspath, dirname, exists, isdir, isfile, join
+from os import environ, listdir, walk
+from os.path import abspath, exists, isdir, isfile, join
 from subprocess import PIPE, Popen
 sys.path.insert(1, '/usr/share/python/')
 from debpython.version import SUPPORTED, debsorted, vrepr, \
@@ -74,8 +74,7 @@ def get_package_files(package_name):
     if process.returncode != 0:
         log.error('cannot get content of %s', package_name)
         exit(2)
-    for line in stdout:
-        line = line.strip('\n')
+    for line in stdout.split('\n'):
         if line.endswith('.py'):
             yield line