Otherwise we aren't gaining any actual security from AppArmor.

Apertis: https://phabricator.apertis.org/T3853



Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6790

Signed-off-by: Simon McVittie <smcv@collabora.com>

gvfs now has a single AppArmor profile named /usr/lib/gvfs/gvfs{d,}-*
which won't be matched by any of the old patterns.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6494

When Prestwood is started as either a systemd service or a child
process of Canterbury, this is what it will get.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6222

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6123

Since the project does not use gschemas, it does not need to
compile schemas at postinst

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6117

Typo in .arcconfig prevent to use git phab attach properly

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6116

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

The signal handler doesn't do anything except exit unsuccessfully,
which is the same thing that would happen if we were interrupted
by a signal. exit() is also not async-signal-safe, so calling it
in this context is undefined behaviour, although _exit() would
be OK.

The cleanup function also doesn't do anything, so don't register it.

The initialization function also doesn't do much, so inline it into
its only caller.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5501

As required by Debian Policy §8.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5498

Our toolchain now produces -dbgsym packages automatically.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5497

- The library is installed to a multiarch location now
- Explicitly select /usr/lib for libexecdir, similar to D4606
- Do not explicitly use dh_systemd or dh_autoreconf, they are now
  the default

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5496

Prestwood has a D-Bus API to get mount points and local media paths,
but it has no such thing for UPnP; so now that we do not notify
Canterbury about UPnP shares, there is no point in maintaining
this list.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5494

This is no longer needed.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5493

These structs are allocated and (in most cases) leaked, but are
otherwise never used for anything.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5492

We don't actually use it here anyway. We also don't check for it, so
the fact that we could successfully #include it in the past was pure
coincidence (presumably one of our dependencies used to provide it).

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5495

Mathieu Duponchelle authored 8 years ago and Andrej Shadura committed 8 years ago

This serves two purposes:

1. hotdoc won't warn about any incorrect documentation in
   the generated sources.
2. We don't need to remove html in other comments anymore.

Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4488

Mathieu Duponchelle authored 8 years ago and Andrej Shadura committed 8 years ago

And reduce our extensions requirements to the newly-consolidated
hotdoc packages.

+ Update depends in debian/control

Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4489

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4330

+ activate the devhelp extension and update the build-depends
+ use tar-ustar to allow us to have filenames longer than
  99 characters in archives.

The text for the standalone markdown documentation was taken
from the gtk-doc files removed in a previous commit.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4128

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4127

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4126

This is not how we expose documentation, and this file
was only a half-completed template.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4125

Copy pasting a TODO file from project to project is absolutely
useless.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4124

Latter commits will replace it with hotdoc

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4123

summary_:
Added macros DEBUG, CRITICAL, WARNING for g_debug,g_critical,
g_warning respectively.

Signed-off-by: Nandini Raju <Nandini.Raju@in.bosch.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D709

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

This fleshes out the Prestwood AppArmor profile a little, fixing most of
the AppArmor ALLOWED messages I see in the journal after booting. It
does not fix the ALLOWED messages for the currently-unconfined parts of
GVFS which Prestwood uses.

It adds:
 • abstractions/namespace to allow network access for UPnP shares
 • Access for Canterbury’s media manager to query mounts and shares
 • Similarly for Frampton
 • Access to GVFS for remote volume monitoring

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3554

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3553

Abhiruchi authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Abhiruchi Gupta <abhiruchi.gupta@in.bosch.com>
Differential Revision: https://phabricator.apertis.org/D893

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

If the -sections file isn't being stored in git, we need to explicitly request
to rebuild sections, or we may end up with a broken (re)build.

See D2043.

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Aleksander Morgado <aleksander.morgado@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D2014

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Aleksander Morgado <aleksander.morgado@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1999

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Aleksander Morgado <aleksander.morgado@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1980

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Aleksander Morgado <aleksander.morgado@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1979

Aleksander Morgado authored 9 years ago and Sjoerd Simons committed 9 years ago

https://www.gnu.org/software/automake/manual/html_node/Multiple-Outputs.html



Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Aleksander Morgado <aleksander.morgado@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1978

Simon McVittie authored 9 years ago and Sjoerd Simons committed 9 years ago

Similar to D1443.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D1647