Skip to content
Snippets Groups Projects

managerd: fix ref used on successful upgrade

Merged Frederic Danis requested to merge wip/fdanis/8609-refs-ordering into apertis/v2023dev1
All threads resolved!

AUM does not set the right refs to the repo commit when the upgrade contains development and release entries in its ref-bindings, e.g. it will use v2022dev3 instead of v2022 if both are present.

When adding ref-bindings to a commit, OSTree sort them in default alphabetic order using strcmp().

This commit looks for the correct ref for the repo commit.

https://phabricator.apertis.org/T8609

Signed-off-by: Frédéric Danis frederic.danis@collabora.com

Edited by Frederic Danis

Merge request reports

Merge request pipeline #347556 passed

Merge request pipeline passed for c32d6c9a

Merged by Ryan GonzalezRyan Gonzalez 3 years ago (Feb 28, 2022 2:31pm UTC)

Loading

Pipeline #348920 passed

Pipeline passed for c32d6c9a on apertis/v2023dev1

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ryan Gonzalez
  • Andre Moreira Magalhaes
  • Apart from that and really nitpicking, could you please make sure the new changes follow the current coding style? (space after parenthesis for function calls, function names as new line on method declarations, etc).

    No need to change other places (if any) that are not being touched by the changes here but would be good to make sure new changes follow the current style.

    That should make the code much nicer to read and maintain.

    Edited by Andre Moreira Magalhaes
  • Frederic Danis added 2 commits

    added 2 commits

    • d56abe3c - managerd: fix ref used on successful upgrade
    • c32d6c9a - Release apertis-update-manager version 0.2020.32

    Compare with previous version

  • Frederic Danis mentioned in merge request !88 (merged)

    mentioned in merge request !88 (merged)

  • Ryan Gonzalez resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading