Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Switch from deprecated pkg-config to pkgconf.
Switch from systemd to systemd-dev which contains now pkg-config files.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

aum_get_metadata_collection_refs() checks whether the commit has
ref-bindings before trying to duplicate them, but it unconditionally
tries to log them.  This results in a null pointer dereference if they
are missing.

Move the logging of references into the conditional block, and log a
different message if no references are found.

Fixes: b66b0704 ("Use separate function for gathering refs from commit")
Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

In order to avoid confusions with the different types of package tests
that can be enabled rename the test metadata file to follow a better
pattern and rationale.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

The PWD variable is not set by GNU make and therefore will have whatever
value it has in the environment, which may not be the actual current directory.

See: https://lintian.debian.org/tags/debian-rules-calls-pwd



Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

This version is already in Apertis v2021

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

dbus 1.14.0 officially deprecates the use of /etc/dbus-1 for
dbus policy from packages.

See https://salsa.debian.org/lintian/lintian/-/commit/7e1577c16851b1a3d8c8cc2e3076e39a12e68bce



Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

In order to test newer version before they land in the main branches
enable running tests on MR.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

AUM does not set the right refs to the repo commit when the upgrade
contains development and release entries in its ref-bindings, e.g. it will
use v2022dev3 instead of v2022 if both are present.

When adding ref-bindings to a commit, OSTree sort them in default
alphabetic order using strcmp().

This commit looks for the correct ref for the repo commit.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

On U-Boot platforms the default bootlimit is set in the bootloader
itself with `CONFIG_BOOTCOUNT_BOOTLIMIT=3` (see the
`apertis/imx6/0003-mx6sabrelite-enable-bootcount.patch` and
`apertis/renesas/0003-renesas-enable-bootcount.patch` patches), so let's
default to three failed boots before rollback here to have a more
consistent behavior across platforms.

This in particular affects the UEFI platforms (amd64).

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Sudarshan CP authored 3 years ago and Frederic Danis committed 3 years ago

Signed-off-by: Sudarshan C P <sudarshan.cp2@in.bosch.com>

Moses Christopher authored 4 years ago and Frederic Danis committed 3 years ago

New nvmem backend added to boot-state.
This backend supports update rollback mechanism for
TI AM335x's SOC or processor which has RTC scratch registers.
For boot-state mechanism RTC scratch_register2 fields used as below
 - byte zero hold boot count value
 - byte one hold the update available state
 - byte two hold the version
 - byte four hold boot count magic

Signed-off-by: Moses Christopher <BollavarapuMoses.Christopher@in.bosch.com>

Without udisks2 and libblockdev-crypto2 only online updates are
supported.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Fix the error below when invoking `gpb dch`:

    re.error: bad escape \T at position 38

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Previous commit 762c178b introduces an endless loop, preventing AUM to
run correctly on EFI systems.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

../managerd/boot-state-efi.c: In function ‘aum_boot_state_efi_read_dir’:
../managerd/boot-state-efi.c:78:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
   78 |   while (conf_file_name_ = g_dir_read_name(dir_name))
      |          ^~~~~~~~~~~~~~~
../managerd/boot-state-efi.c: In function ‘aum_boot_state_efi_conf_file_save’:
../managerd/boot-state-efi.c:126:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  126 |   while (conf_file_name = g_dir_read_name(dir_name))
      |          ^~~~~~~~~~~~~~
../managerd/boot-state-efi.c:145:1: warning: control reaches end of non-void function [-Wreturn-type]
  145 | }
      | ^

/usr/include/glib-2.0/glib/gmacros.h:1049:10: warning: ‘options’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1049 |     { if (_ptr) (cleanup) ((ParentName *) _ptr); }                                                              \
      |          ^
../managerd/main.c:382:24: note: ‘options’ was declared here
  382 |   g_autoptr (GVariant) options;
      |                        ^~~~~~~

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

AUM crashes when an update is done OTA or using a downloaded bundle, i.e.
not an encrypted bundle on an USB drive and so without a loopback set.

Check presence of a loopback before trying to remove it.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Moses Christopher authored 4 years ago and Frederic Danis committed 3 years ago

The following boot state backend's throw a critical message,
when the respective boot state backend is not selected
  - boot-state-uboot-env
  - boot-state-uboot-ext
  - boot-state-efi

Reduce the log level by using g_message instead of g_critical

Signed-off-by: Moses Christopher <BollavarapuMoses.Christopher@in.bosch.com>

Gireesh Hiremath authored 4 years ago and Frederic Danis committed 3 years ago

If target failed to unlock upgrade bundle file,
required to notice the error.

Signed-off-by: Gireesh Hiremath <Gireesh.Hiremath@in.bosch.com>