New LAVA version will check kernel messages to make sure the
kernel can start correctly.

This commit adds the kernel_start_message variable to the
job templates to test for any string as a valid kernel message
after the bootloader is properly matched.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7638

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Ifconfig's output format has changed recently, leading to parsing
failures. Use iproute's output, as it's more stable.

Apertis: T4500

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7549

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Apertis: T4500

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7544

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Apertis: T4500

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7539

There is no need to test for all locales in minimal
images.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7527

Move tests requiring bash to the bottom, so it's installed after
all non-bash-requiring tests have been performed.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7528

These are quite difficult to port to dash fully right now, revert to
bash.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7523

This test actually requires some locale po files installed
by the apertis-tests package in a data dir to execute the
tests.

So revert the previous change to execute this test from git,
and instead keep using the apertis-test package.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7509

This code is unmaintainable as is, and is buggy.

If run with set -e, it would not detect failures properly and
fail only because test would fail with an unquoted $s argument,
which would be unset because echo would fail to run after the
command failed.

Instead, let's just drop this horrific wizardry and use plain
simple || return $? to pass the return code further on.

Also, reduce the function of DEBUG to enabling all output, defaulting
to disabling both stdout and stderr. The original code didn't do
what it said it was doing anyway.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7506

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Martyn Welch <martyn.welch@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7504

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Martyn Welch <martyn.welch@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7503

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Martyn Welch <martyn.welch@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7502

- Use sed instead of bash replacing substitutions
- Use = instead of == in [.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Martyn Welch <martyn.welch@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7501

Luis Araujo authored 7 years ago and Andrej Shadura committed 7 years ago

Before creating the temporary directory for tests, create the
baseworkdir path for it.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7500

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Add bash as a dependency and move to the SDK template.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7498

Luis Araujo authored 7 years ago and Andrej Shadura committed 7 years ago

This commit gets the librest, libsoup and glib-gio-fs
tests to run directly from git. It also removes the
unneeded package dependency on chaiwala-tests.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7494

The only tests remaining not ported are tumbler tests and a few
SDK tests.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7497

SDK images should have bash preinstalled anyway, but we mark these
tests in their definition for clarity so that it's not forgotten
if anything changes.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7495

POSIX shell doesn't support RANDOM variable getting a new random
number on each read. In fact, we don't need it in most places,
as creating temporary directories is better done by mktemp, and we
don't really need to randomise the port number.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7496

The recommended way to run tests is from the git repository
directly since most of the scripts are adapted to run tests
this way.

This commit also removes the unneeded chaiwala-tests package
dependency.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7493

The recommended way to run tests is from the git repository
directly since most of the scripts are adapted to run tests
this way.

This commit also removes the unneeded chaiwala-tests package
dependency.

Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7492

As dash doesn't support trapping on ERR, we should ignore the
error when we cannot remove the trap.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7489

Testing variables for emptiness (-z) on non-emptiness (-n) needs
variables to be properly quoted, otherwise it may not work correctly.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7488

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7487

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7486

"Test failed! 0 > 0" in the logs looks really confusing.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7485

Fix some more bashishms, and actually change the hashbang.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Denis Pynkin <denis.pynkin@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7474

Instead of iterating over the titles etc twice, first to run tests,
second to print the results, just print the results immediately
after running the tests.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Denis Pynkin <denis.pynkin@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7478

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Denis Pynkin <denis.pynkin@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7477

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Denis Pynkin <denis.pynkin@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7476

- lists, not arrays
- [, not [[
- $$, not $BASHPID
- put each local on its own line
- which from debianutils, not type -P

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Denis Pynkin <denis.pynkin@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7475

POSIX doesn't allow trapping on ERR, trap on EXIT instead and
check $?. Where cleanup is necessary before handling errors,
save the exit code and pass it to test_failure a bit later.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7470

Checking the return code inside the *_failure functions makes it
possible to use it with either ERR or EXIT trap.

Replace previously deployed workarounds to use *_failure as is.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7472