Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4435

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

ofono runs as root, so having the "malicious" LD_PRELOAD module read
/home/user/.bash_history requires it to exercise CAP_DAC_OVERRIDE,
leading to an AppArmor denial that doesn't match what we expect. Try
to read /etc/shadow instead, and update the expected denials
accordingly.

With that change, there's no real need for the "malicious" code to use
GLib, so use stdio instead.

Apertis: https://phabricator.apertis.org/T1848



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4388

The ofonod wrapper script uses pkill 'ofonod$' to terminate the
malicious ofonod process. This call has the bad idea of killing every
process which name ends in ofonod. This include "test-ofonod" which
is the master script that started ofonod wrapper.

Remove pkill since we have the pid of the process to kill.
Also it's not needed to change the process name.

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4386

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4383

Auto-discovering ${top directory}/resources instead of
/usr/share/chaiwala-tests/resources means we don't have to depend
on the legacy chaiwala-tests package.

We still need to hard-code /usr/lib/apertis-tests to load the
LD_PRELOAD hack that we use to simulate a compromised pulseaudio
process, but we can reduce the test/fix cycle for the rest by
running it directly from a git checkout.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4382

This package is no longer required as the test is deprecated.

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4345

This test is deprecated as a new test need to be developed to be run
from Canterbury (https://phabricator.apertis.org/T2119

).

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4344

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>

Hopefully this should help debugging T2504 by telling us what's going on
in the http server.

Need to run the test with DEBUG=2 to have these extra debug info.

Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Reviewed-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D4354

We reported in https://bugzilla.gnome.org/show_bug.cgi?id=755181


a "weird" behaviour that has now been fixed upstream.

Follow the recommendation given in the comment to remove the
calls to get_parent(), and remove the comment itself.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4160

Reviewed-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4350

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>

This syntax is wrong, it generates the following error:
File "/usr/lib/python3/dist-packages/apertis_tests_lib/bluez.py", line
  557, in __show_menu
      name = str(i['org.bluez.Device1'].get(['Name'], address))
      TypeError: unhashable type: 'list'

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4340

Reviewed-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4310

In a fresh VM, following the instructions in
https://wiki.apertis.org/QA/Test_Cases/bluez-phone


means that the device object has not yet been created, fiddling
with d-feet showed me that `StartDiscovery` was necessary for this
to happen, which is called by scan_for_device.

The result was an enigmatic D-Bus error message:

Create device failed org.freedesktop.DBus.Error.UnknownObject: Method
"Pair" with signature "" on interface "org.bluez.Device1" doesn't exist

which is solved with this patch.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4264

Previously, this test didn't provide an obvious indication that it
had all succeeded, and assumed that it was run as root with $(pwd) in
/usr/lib/apertis-tests or a git clone of apertis-tests.

To use this as a manual test:

    Prerequisites:
        - apertis-tests installed (sudo apt install apertis-tests)
    Steps:
        sudo /usr/lib/apertis-tests/common/sanity-check
    Successful result:
        Output ends with "# Sanity check successful"
    Failing result:
        Output ends with "Failed, see above for details" or ends with
        neither of the expected messages
    Diagnosing failures:
        Look for "TEST_RESULT:fail:" in the output (it may appear more
        than once), and look for warnings/errors shortly before each
        occurrence of that message

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4284

os-release pretended we were Ubuntu for a while, to make packages
with different build steps for Debian and Ubuntu follow Ubuntu-like
code paths. This has now been fixed.

Reviewed-by: Simon McVittie <smcv@collabora.co.uk>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4272

As the SDK image is supposed to run in a virtual machine,
there is no need to run its tests in a board.

This commit changes the LAVA profile configuration so the
SDK AMD64 image tests will be executed using the i386 device
(virtual machine).

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4175

This test is being deprecated and will be replaced by a new
webkit2gtk layout test.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4149

Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>

On a target board, Status Bar hides the top of the window so
the text from clutter-i18n-gettext looks like not working.
To show the text in a position not to be interfered by Status
Bar, it needs to be moved slightly below.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4151

It seems that importing pyopenssl now takes longer than it did before,
which affects each iteration of the telepathy-gabble tests, and makes
them take a little more than the 30 minute timeout on an i.MX6.

Double the timeout again to prevent test failures even when the tests
are making progress.

Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Reviewed-by: Luis Araujo <luis.araujo@collabora.com>
Differential Revision: https://phabricator.apertis.org/D4122

Signed-off-by: Justin Kim <justin.kim@collabora.com>

This commit explicitly adds the dbus-tests package dependency for
the dbus-dos-reply-time test definition.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4107

Even if the port is already in use, simple-httpd doesn't report and
just show a message "Waiting for requests...". It's a simple bug of
example of libsoup2.4.
Fortunately, without a specific port, simple-httpd will pick up
a port which is available. Then, we can parse its stdout to parse
running port.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4080

Otherwise, when running check-dbus-services manually, it will
launch a pager.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3903

We fixed UserPrompter0 by moving to systemd activation.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3901

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3899

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3898

This came from the chaiwala-btrfs package, which we haven't shipped
since 15.12.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3897

T2326, aka #428, has now been fixed.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3896

Both the tracker-indexing-local-storage and apparmor-tracker tests
are currently being executed manually since they require the
/home partition properly mounted in the test image and that is not
the way LAVA boots the test image.

This is a temporary solution until LAVA can properly mount all the
available partitions in the test image.

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3482

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3775

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3773

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3772

The Tracker services are started on-demand, while Xorg might not be
installed.

Also continue testing if one of these assertions fails: just log it
as "not OK".

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3771

We're effectively asserting that all these processes are running,
so we should look at whether they, in fact, *are* running, and
if not, why not.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3639

If we fail to read the AppArmor profile or other required information
due to a time-of-check/time-of-use difference (the process exits)
then that's fine. Otherwise, it's a problem and we should fail,
although we might as well continue testing and get more complete
results.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3770

Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3638