Don’t keep trace files open, reopen them each time
All threads resolved!
All threads resolved!
Keeping files open at all times prevents them from being cleaned up properly, and when clean-ups happen, the existing code couldn’t handle it properly and would either error out, or continue logging into an invisible file (referenced to only by its open file descriptor).
Merge request reports
Activity
Filter activity
- Resolved by Sjoerd Simons
This looks fine overall; I do wonder however if it's worth to explicitly catch exceptions in job_trace and the alias function in case of failures, to avoid failing build jobs in case there are issues with the tracing
added 1 commit
- e2490297 - Catch, log and ignore OSError exceptions in job tracing code
- Resolved by Sjoerd Simons
Please register or sign in to reply