- Mar 23, 2022
-
-
Andrej Shadura authored
The Docker entrypoint saves effort for users: they can map a config inside a container based on the stock image without having to rebuild it. Since the config is no longer necessary inside the image, don’t install it. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
The logging subsystem is more versatile and provides more features than manual log prints. Timestamps are very often useful for tracking down timing issues, enable them for the root logger. This current logging configuration doesn’t include the module/logger name in the message format as it clutters the logs. This may be revisited later when the logging system is overhauled to support structured logging and better tracing. Quart/Hypercorn’s logger has its own log printing handler, so as we currently only print logs on the stdout, we need to disable the propagation to prevent access logs from being duplicated. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Default arguments are not cloned upon a function call, so once a default value is mutated, it will be passed on to the function the next time it is called, similarly to static variables in C. Since this is clearly a footgun, don’t do that. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
- Mar 14, 2022
-
-
Andrej Shadura authored
We don’t test with 3.8 anymore, production systems run 3.9 too, so this doesn’t reflect the reality. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
If an exception happens in the stream iterator, there is no guarantee the response is cleaned up, potentially leading to resource leaks. To avoid this, call .aclose() from the finally section. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
We actually want the routes to be imported when we use the blueprint. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Maximum connection limits run out quickly when talking to the backend, possibly because they don’t expire for some not completely understood reasons. Since the backend doesn’t talk HTTP/2 or TLS, connection pooling doesn’t get utilised as much (or at all), so it doesn’t make much sense to have one client rather than create a client per request or a related group of requests thus keeping their lifetimes limited and avoiding the issue altogether. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
- Mar 13, 2022
-
-
Andrej Shadura authored
Since we’re currently pooling connections in a single client, 100 connections is a too low a limit given the number of connections we need to handle. In future, we should probably reduce the reliance on a single client and only reuse a global client in some cases but not in the others. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
- Mar 12, 2022
-
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
5xx errors tend to be from transient issues, so it may be worthwhile retrying in such cases. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
The proxy support in websockets (proxied_ws) is closely tied to the version 8 of websockets, which doesn’t support Python 3.10: obs_proxy.client: Caught an exception: obs_proxy.client: As of 3.10, the *loop* parameter was removed from Lock() since it is no longer necessary Since we build Docker images based on Debian Bullseye, this doesn’t yet matter as Python 3.9 is the default in Bullseye. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Python 3.10 removed this parameter. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
This is used by the proxy client to verify the payload has been uploaded correctly. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Actually make the new blueprint part of the app. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Some scaffolding to integrate the uploader later. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Given the absence of a standard way to do this, use a custom Patch-Content-Range header to specify which chunk is being uploaded. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
- Mar 10, 2022
-
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
Andrej Shadura authored
To make it easier to investigate failures, only delete the temporary file if the upload succeeds. If it fails, dump extra details about the error. Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-
- Mar 05, 2022
-
-
Andrej Shadura authored
Signed-off-by:
Andrej Shadura <andrew.shadura@collabora.co.uk>
-