Draft: whitelists: Add delta_package_ignore_list

assigned to @daissi

@wlozano What do you think about this way to whitelist delta flags? It's not perfect, but at least it should avoid having outdated whitelists.

I was not the reviewer on this one, that is why I missed it. I think we should decouple the stats reasoning from the reasoning, which make thing clearer. Also, my understanding is that the reasoning probably will remain the same across several releases, in which case we can use some yaml anchors and aliases to avoid too much duplication. Finally, there might be cases that generic aliases can be used for several packages, for instance 'Drop GPL-3 code'.

Does it make sense?

I was not the reviewer on this one, that is why I missed it.

My bad! I realized today that I had also forgotten for another MR.

I think we should decouple the stats reasoning from the reasoning, which make thing clearer.

What about this way?

  DELTA_PACKAGE_SHORTSTAT:
    v2024:
      adduser:
        "1 file changed, 1 insertion(+), 1 deletion(-)"
    v2025dev3:
      adduser:
        "1 file changed, 1 insertion(+), 1 deletion(-)"
  DELTA_PACKAGE_REASON:
    v2024:
      adduser:
        "Change default shell to /bin/sh"
    v2025dev3:
      adduser:
        "Change default shell to /bin/sh"

Also, my understanding is that the reasoning probably will remain the same across several releases, in which case we can use some yaml anchors and aliases to avoid too much duplication. Finally, there might be cases that generic aliases can be used for several packages, for instance 'Drop GPL-3 code'.

I totally agree this was my initial idea.

What about

  DELTA_PACKAGE_IGNORE_LIST:
    v2024:
      adduser:
        shortstat: "1 file changed, 1 insertion(+), 1 deletion(-)"
        reason: "Change default shell to /bin/sh"
    v2025dev3:
      adduser:
        shortstat: "1 file changed, 1 insertion(+), 1 deletion(-)"
        reason: "Change default shell to /bin/sh"

Much better!

changed this line in version 4 of the diff

I pushed this change and also I've added two ways of using anchors as an example.

I love it!

Please finish the implementation (when you have time) with this approach.

added 8 commits

• 74c68b24...20afdcd3 - 7 commits from branch master
• 12903bf5 - whitelists: Add DELTA_PACKAGE_IGNORELIST

Compare with previous version

added 15 commits

• 12903bf5...fc3ca820 - 14 commits from branch master
• 0111cbd9 - whitelists: Add DELTA_PACKAGE_IGNORELIST

Compare with previous version

requested review from @wlozano

Btw, in the whitelist we mix uppercase and lowercase for the list names, probably we should align that.

added 10 commits

• 0111cbd9...4a933822 - 9 commits from branch master
• 2a634e2d - whitelists: Add DELTA_PACKAGE_IGNORELIST

Compare with previous version

added 1 commit

• 0e13d748 - whitelists: Add DELTA_PACKAGE_IGNORE_LIST

Compare with previous version

added 1 commit

• 03f87ce3 - whitelists: Add DELTA_PACKAGE_IGNORE_LIST

Compare with previous version

added 1 commit

• cb706fee - whitelists: Add DELTA_PACKAGE_IGNORE_LIST

Compare with previous version

added 1 commit

• 7637becd - whitelists: Add DELTA_PACKAGE_IGNORE_LIST

Compare with previous version

added 1 commit

• 961baeff - whitelists: Add delta_package_ignore_list

Compare with previous version

changed title from Draft: whitelists: Add DELTA_PACKAGE_IGNORELIST to Draft: whitelists: Add delta_package_ignore_list

added 5 commits

• 961baeff...bda313a0 - 4 commits from branch master
• 81b7df4a - whitelists: Add delta_package_ignore_list

Compare with previous version