Add new report displaying the packaging delta size

This information is useful to target packages for which our changes may potentially be upstreamed to Debian to ease the next rebase.

Signed-off-by: Dylan Aïssi dylan.aissi@collabora.com

assigned to @daissi

added 1 commit

• f1635bc7 - Increase timeout for packaging-check-delta

Compare with previous version

There is still an issue for packages without any delta: they are not cached!

The scan (without using cache) of all packages took ~ 2 hours.

added 1 commit

• 620af275 - Don't report if no delta

Compare with previous version

added 1 commit

• 596ef05e - Fix cache usage for packages without delta

Compare with previous version

resolved all threads

requested review from @wlozano

All these commits need to be squashed before merging, let's do that after (or during) the review to avoid another pipeline to run.

marked this merge request as ready

added 1 commit

• d331b26b - Add new report displaying the packaging delta size

Compare with previous version

resolved all threads

approved this merge request

From a high level view this looks great! After checking the report it looks like there are 413 packages with delta, so probably it would be useful to set different type of severity, and raising it to "warning" for some of them.

For instance (just an example, to discuss) info: default warning: packages which change more than 50 lines

As you know the only issue with this approach is the increase in the pipeline time which you already addressed with the cache. But I have one doubt, the information about commit and version should already be available in other cache files, since the concept of cache is already implemented, why did you store it under delta as well?

unapproved this merge request

I am unapproving this, because it looks like we still need some discussion.

Probably it will be useful to reuse the cache options like DISABLE_CACHE, to be aligned.

added 1 commit

• e1b4a878 - Add DISABLE_CACHE support for packaging-check-delta

Compare with previous version

added 1 commit

• b8122bb5 - Refactor packaging-check-delta to compute delta for all branches

Compare with previous version

added 1 commit

• 81124fc5 - Refactor packaging-check-delta to compute delta for all branches

Compare with previous version

added 1 commit

• 419766f4 - packaging-check-delta: whitelist some releases

Compare with previous version

added 7 commits

• f2674d86 - 1 commit from branch master
• 691c30ff - Add new report displaying the packaging delta size
• 97fcd863 - Add DISABLE_CACHE support for packaging-check-delta
• 319b4370 - Refactor packaging-check-delta to compute delta for all branches
• e6cc604b - packaging-check-delta: whitelist v2023, delta are no longer relevant
• 0fd830da - packaging-check-delta: Improve cache usage
• fe2d17cf - packaging-check-delta: increase timeout since now we track more branches

Compare with previous version

added 2 commits

• 759fd041 - packaging-check-delta: increase timeout since now we track more branches
• ee2d0fec - packaging-check-delta: Improve cache usage

Compare with previous version

marked this merge request as draft

added 3 commits

• 658008e6 - Simply reported version since the upstream one is no longer available in cache
• eda0f4d8 - Add delta summary
• 70e46da0 - Use functions to convert tag to version and vice-versa

Compare with previous version

marked this merge request as ready

added 1 commit

• ba83a987 - Remove unused DELTA_PACKAGE_IGNORELIST

Compare with previous version

Changes look OK to me, so I am approving it. However, probably it will be better to squash some commits to have a cleaner history.

approved this merge request

resolved all threads

added 1 commit

• 1f1c697d - Add new report displaying the packaging delta size

Compare with previous version

resolved all threads

merged