Skip to content
Snippets Groups Projects

Adopt exponential backoff when retrying

Merged Emanuele Aina requested to merge wip/em/gentler-retrying into master

The current naive approach at retrying is not exactly gentle: if the server is overloaded we retry right ahead making the problem just worse.

See https://encore.dev/blog/retries for a fun explanation of how the naive approach can be catastrophic.

Fortunately the tenacity library allow us to add a bounded exponential backoff while also making the code easier to understand.

This should make the dashboard behave much better toward GitLab and OBS when they hit some issue.

Task: https://phabricator.apertis.org/T10169

Edited by Emanuele Aina

Merge request reports

Pipeline #627471 passed

Pipeline passed for 9fc43368 on wip/em/gentler-retrying

Approved by

Merged by Emanuele AinaEmanuele Aina 1 year ago (Nov 3, 2023 2:07pm UTC)

Merge details

  • Changes merged into master with 9fc43368.
  • Deleted the source branch.

Pipeline #628033 passed

Pipeline passed for 9fc43368 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading