Skip to content
Snippets Groups Projects

packaging-check-settings: Improve the gitlab-rulez checks

Merged packaging-check-settings: Improve the gitlab-rulez checks
wip/em/gitlab-rulez-improvements into master
All threads resolved!
Merged Emanuele Aina requested to merge wip/em/gitlab-rulez-improvements into master
All threads resolved!

Move the call to gitlab-rulez to a separate job to shorten a bit the already extra-long packaging-data-fetch-downstream job, and shift it to the check stage as it seems more appropriate.

This also causes the pipeline to properly honor the $GITLAB_RULES_URL variable, as it stops using the hardcoded gitlab.apertis.org/infrastructure/apertis-infrastructure URL in bin/packaging-data-fetch-downstream.

Reporting is also improved by showing details about the incorrect settings by using the recently introduced --output json option in gitlab-rulez, currently only available starting from Debian Trixie.

Example:

image

Edited by Emanuele Aina

Merge request reports

Pipeline #605234 passed

Stage: lint
Stage: fetch
Stage: check
Stage: plan
Stage: render
Stage: trigger

Pipeline passed for 47010e05 on wip/em/gitlab-rulez-improvements

Approved by
Dylan Aïssi

Merged by Dylan AïssiDylan Aïssi 1 year ago (Sep 4, 2023 2:00pm UTC)

Merge details

  • Changes merged into master with 47010e05.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #605541 passed

Stage: lint
Stage: fetch
Stage: check
Stage: plan
Stage: render
Stage: trigger
Stage: deploy

Pipeline passed for 47010e05 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dylan Aïssi
  • Emanuele Aina changed the description

    changed the description

  • Emanuele Aina added 2 commits

    added 2 commits

    • 1f102770 - packaging-check-settings: Improve the gitlab-rulez checks
    • 6c764a7a - ci: Parametrize $GITLAB_RULES_URL on $OSNAME

    Compare with previous version

  • Emanuele Aina added 4 commits

    added 4 commits

    • 9d928271 - 1 commit from branch master
    • 783b6e3c - classes: Add project_name_to_package_name()
    • ce75fd17 - packaging-check-settings: Improve the gitlab-rulez checks
    • 47010e05 - ci: Parametrize $GITLAB_RULES_URL on $OSNAME

    Compare with previous version

    Toggle commit list
  • Emanuele Aina resolved all threads

    resolved all threads

  • Dylan Aïssi approved this merge request

    approved this merge request

  • Dylan Aïssi enabled an automatic merge when the pipeline for 47010e05 succeeds

    enabled an automatic merge when the pipeline for 47010e05 succeeds

  • Dylan Aïssi merged

    merged

    • Please register or sign in to reply
    Apertis Website Terms of Use Privacy Policy