Drop osc-setup, rely on OSC_CONFIG being set

The pkg group now sets the OSC_CONFIG environment variable in its CI settings to provide the whole configuration for the connection to OBS, removing the need for the osc-setup script to take the OSC_USERNAME and OSC_PASSWORD variables and put them in ~/.oscrc.

The CI/CD settings of the tests/dash> project used by the test pipeline have already been updated to drop OSC_USERNAME and OSC_PASSWORD while introducing OSC_CONFIG.

changed the description

added 2 commits

• 49b7991a - 1 commit from branch master
• 876ae1b4 - Drop osc-setup, rely on OSC_CONFIG being set

Compare with previous version

requested review from @andrewsh

How does this work?

def identify_conf():
    # needed for compat reasons(users may have their oscrc still in ~
    if 'OSC_CONFIG' in os.environ:
        return os.environ.get('OSC_CONFIG')
    if os.path.exists(os.path.expanduser('~/.oscrc')):
        conffile = '~/.oscrc'
    else:
        conffile = os.environ.get('XDG_CONFIG_HOME', '~/.config') + '/osc/oscrc'

    return conffile

resolved all threads

approved this merge request

@andrewsh any reason for not merging?

It’s too late for my brain to think straight, so I decided to leave it until morning or until you merge it

resolved all threads

merged

mentioned in commit apertis-docker-images@de505ba0

mentioned in merge request apertis-docker-images!247 (merged)

mentioned in commit apertis-docker-images@a185fe21