Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To have early warnings add a check for env variables.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

After improving the folding code do a clean up to make it easier to read
and maintain.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To avoid continuing running commands in case of an error abort the
execution immediately.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Drop the shift after the main case for arguments as it is bogus, and
triggers an error in case of multiple options like -g -o.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To align with other scripts support both NOACT env variable and dry-mode
from command line argument.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To align with other entries fix the use of verbs in logs.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make the script easier to read rework the check for security and updates.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make the use of env variables consistent across infrastructure scripts
use OSNAME and RELEASE when needed.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make it easier to read, move global variables to the top.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Local variables should be lower case, so change them accordingly.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Fix the use of an undefined variable.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The formatting for global variables should be upper case, so fix entries
that don't match this rule.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Rename the variable BRANCHING_GITLAB_API_TOKEN to GITLAB_TOKEN, to make
it consistent with its usage.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Remove old scripts that are not longer used

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Rename function create-mr-pipeline-true to merge-mr to avoid confusions.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The release scripts rely on gitlab scripts that are scattered in the gitlab
folder and that are called from more high level scripts. To make this
interaction cleaner and easier to maintain rework how this is done.

First, merge all the gitlab scripts in a single one with several functions,
one per script. During this process remove the duplicated code.

Second, rework the way these functions are called, to make it easier to read
and maintain.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

While iterating to branches group of packages a var called GROUP is used,
which is confusing as it does not store groups, but a list repos. Also,
this var can be confused by the env var GROUP, which adds more problems.

To avoid such issues, rename it.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The idea of having defaults is useful, however, it might be confusing if
they have little sense. For .custom_globals_default the stage and script
are overridden in every job that uses it, so drop them.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

To make the pipeline cleaner move all the checks to the pre stage. It is
worth to mention that the check in the script sectio of
.custom_globals_default has little value as the script is overridden
in the jobs.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The pre state is meant to perform some sanity checks before running the
pipeline. Unfortunately, it is buggy and it is included in every pipeline,
even when it was not intended for that.

Rework it to make it more consistent and to run additional checks. In this
process also include a manual step to ensure that the user has checked the
value of the variables.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Expose CI variables to make it easier to newcomers to run CI pipelines.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The variable CI_SERVER_HOST is a Gitlab CI predefined variable, so there
is no reason to define it here. Drop it to make downstreams life easier.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

After the branching v2025pre QA pipelines need to checked, so update the configuration.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Release v2022 has reached its EOL, so avoid running pipelines for it.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Some of the new tests repos are excluded from the scheduled pipelines since
they not need to update any binary.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

By default gitlab-rulez defines the default branch based on the
value of current_release_branch which is currently "apertis/v2025pre".

But some packages have been dropped from Apertis in previous releases,
that means they don't have the default branch. Thus we need to teach
gitlab-rulez what is the latest branch to use as default branch.

linuxptp was in the v2023_repositories list since its default branch
was apertis/v2023 because it got removed after. Now that it has been
re-added in apertis/v2025pre, gitlab-rulez can rely on the
current_release_branch to define its default branch.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Co-authored-by: Walter Lozano <walter.lozano@collabora.com>

The aptly repositories need to be created way before the publishing
begin on the OBS side. Followed by the publisher service restart. And
then, further followed by the republishing of the OBS repositories

Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

In case a job cannot be retried continue processing the rest of the jobs.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

In case that job fail for unknown issues the information might fail to be
retrieved. Log this accordingly so it can be investigated.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

For a short time during branching the new repository on OBS doesn't
have the right settings. i.e. rebuild="local" block="never" and users
are not defined during the creation of the new repository
(with obs-repository-copy) but only few steps later with obs-prjconf-update.

Thus, to avoid unnecessary rebuilds during this short period of time,
we need to disable builds at the beginning of the process and then
re-enable at the end of the process.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

This package has been reintroduced in v2024+.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Walter Lozano authored 10 months ago and Dylan Aïssi committed 10 months ago

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 10 months ago and Dylan Aïssi committed 10 months ago

The function get_buildid is aimed to get a specific build id or the latest
from orchestrator builds. With this idea in mind the function
get_latest_orchestrator_buildid was created but it was never used.

Fix the issue by calling the function if latest is passed.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 10 months ago and Dylan Aïssi committed 10 months ago

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 10 months ago and Dylan Aïssi committed 10 months ago

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 10 months ago and Dylan Aïssi committed 10 months ago

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>