Fix the code to update infrastructure repo to match expectations.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 6 months ago and Dylan Aïssi committed 6 months ago

To make the code more readable and easier to reuse simplify the
check-pipelines by using gitlab-check arguments.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 6 months ago and Dylan Aïssi committed 6 months ago

The current gitlab-check configuration is only used after branching so
rename it accordingly.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 6 months ago and Dylan Aïssi committed 6 months ago

To improve readability define verbosity levels.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 6 months ago and Dylan Aïssi committed 6 months ago

To only print relevant information by default add a debug option.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

In order to improve consistncy and to make the code easier to read move
variables which set the behavior of the code to be in the object. While
doing this rework how config file is handled to avoid changing the values
in memory.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

The functionality of expaning project was implemented as a stand alone
function, but there is no real benefit on doing that. Instead, move
this functionality to the class to make it easier to share data.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

The variable projet seems to be spelled in French rather than English.
Unfortunately both spellings are very similiar, causing a typo.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

Removing the protection on the repos can be risky, for this reason
re-enable it as soon as possible, right after projects have been
updated.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

Following the same approach done for other repos update gitlab-rulez.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

To improve readability create a new template job for the branch-update
tasks. At the same time set the "needs" property to branch-protection-relax,
 which can save some time when running the pipeline in "testing" mode.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

In order to ensure that both gitlab-rulez and its configuration are working
as expected, apply the rules before doing the branching.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

The fold gitlab-scripts contains a set of unmaintained scripts. These
scripts have not been used for ages and make use of Gitlab APIs that are
not longer valid. In this context, they don't have much value, and can
always be checked in git history if needed.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

To make things more tidy move gitlab rulez to its own repo.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

Since as_list will be deprecated soon, switch to the equivalent
iterator=True.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 6 months ago

In order to simply configuration and to avoid duplication drop the use
of python-gitlab.cfg by specifying settings from command line.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

By default gitlab-rulez defines the default branch based on the
value of current_release_branch which is currently "apertis/v2025pre".

But some packages have been dropped from Apertis in previous releases,
that means they don't have the default branch. Thus we need to teach
gitlab-rulez what is the latest branch to use as default branch.

gnome-autoar, nautilus and nautilus-python were in the v2023_repositories
list since its default branch was apertis/v2023 because it got
removed after. Now that it has been re-added in apertis/v2025pre,
gitlab-rulez can rely on the current_release_branch to define its
default branch.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 7 months ago

To make it easier to read and to avoid code duplication move the obs copy
logic to its own script, following the same approach of other release
scripts.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

The stage obs-new-repos-setup is no longer used, so drop it.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Since all these jobs are related move them the same stage. Dependencies
are still enforced by the "needs" property.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

The job branch-protection-tighten is triggered with the same rules as
branch-protection-relax, which is confusing. Instead of making it to
depend on the stage, keep it independent of it thanks to "needs" but
set it to be manual. In this way the user  can to check that everything
is OK and also to allows him to run this job at any stage even if some
of the branching job had failures.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

In order to avoid code duplication rework the scripts that handle repo
branching.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

By default gitlab-rulez defines the default branch based on the
value of current_release_branch which is currently "apertis/v2025pre".

But some packages have been dropped from Apertis in previous releases,
that means they don't have the default branch. Thus we need to teach
gitlab-rulez what is the latest branch to use as default branch.

can-utils was in the v2023_repositories list since its default branch
was apertis/v2023 because it got removed after. Now that it has been
re-added in apertis/v2025pre, gitlab-rulez can rely on the
current_release_branch to define its default branch.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

By default gitlab-rulez defines the default branch based on the
value of current_release_branch which is currently "apertis/v2025pre".

But some packages have been dropped from Apertis in previous releases,
that means they don't have the default branch. Thus we need to teach
gitlab-rulez what is the latest branch to use as default branch.

ne10 was in the v2023_repositories list since its default branch
was apertis/v2023 because it got removed after. Now that it has been
re-added in apertis/v2025pre, gitlab-rulez can rely on the
current_release_branch to define its default branch.

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

By default Gitlab CI will rely on stages to execute jobs. The needs
property is only needed when we want to change this behavior, like
when the jobs depends on other jobs in the same stage or when a job
does not need to wait for others.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To have early warnings add a check for env variables.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

After improving the folding code do a clean up to make it easier to read
and maintain.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 7 months ago

To avoid continuing running commands in case of an error abort the
execution immediately.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 7 months ago and Dylan Aïssi committed 7 months ago

Drop the shift after the main case for arguments as it is bogus, and
triggers an error in case of multiple options like -g -o.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To align with other scripts support both NOACT env variable and dry-mode
from command line argument.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To align with other entries fix the use of verbs in logs.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make the script easier to read rework the check for security and updates.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make the use of env variables consistent across infrastructure scripts
use OSNAME and RELEASE when needed.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

To make it easier to read, move global variables to the top.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Local variables should be lower case, so change them accordingly.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Walter Lozano authored 8 months ago and Dylan Aïssi committed 7 months ago

Fix the use of an undefined variable.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The formatting for global variables should be upper case, so fix entries
that don't match this rule.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Rename the variable BRANCHING_GITLAB_API_TOKEN to GITLAB_TOKEN, to make
it consistent with its usage.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>