Reviewed-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4350

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>

This syntax is wrong, it generates the following error:
File "/usr/lib/python3/dist-packages/apertis_tests_lib/bluez.py", line
  557, in __show_menu
      name = str(i['org.bluez.Device1'].get(['Name'], address))
      TypeError: unhashable type: 'list'

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4340

Reviewed-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4310

In a fresh VM, following the instructions in
https://wiki.apertis.org/QA/Test_Cases/bluez-phone


means that the device object has not yet been created, fiddling
with d-feet showed me that `StartDiscovery` was necessary for this
to happen, which is called by scan_for_device.

The result was an enigmatic D-Bus error message:

Create device failed org.freedesktop.DBus.Error.UnknownObject: Method
"Pair" with signature "" on interface "org.bluez.Device1" doesn't exist

which is solved with this patch.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Differential Revision: https://phabricator.apertis.org/D4264

Previously, this test didn't provide an obvious indication that it
had all succeeded, and assumed that it was run as root with $(pwd) in
/usr/lib/apertis-tests or a git clone of apertis-tests.

To use this as a manual test:

    Prerequisites:
        - apertis-tests installed (sudo apt install apertis-tests)
    Steps:
        sudo /usr/lib/apertis-tests/common/sanity-check
    Successful result:
        Output ends with "# Sanity check successful"
    Failing result:
        Output ends with "Failed, see above for details" or ends with
        neither of the expected messages
    Diagnosing failures:
        Look for "TEST_RESULT:fail:" in the output (it may appear more
        than once), and look for warnings/errors shortly before each
        occurrence of that message

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4284

os-release pretended we were Ubuntu for a while, to make packages
with different build steps for Debian and Ubuntu follow Ubuntu-like
code paths. This has now been fixed.

Reviewed-by: Simon McVittie <smcv@collabora.co.uk>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4272

As the SDK image is supposed to run in a virtual machine,
there is no need to run its tests in a board.

This commit changes the LAVA profile configuration so the
SDK AMD64 image tests will be executed using the i386 device
(virtual machine).

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4175

This test is being deprecated and will be replaced by a new
webkit2gtk layout test.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4149

Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>

On a target board, Status Bar hides the top of the window so
the text from clutter-i18n-gettext looks like not working.
To show the text in a position not to be interfered by Status
Bar, it needs to be moved slightly below.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4151

It seems that importing pyopenssl now takes longer than it did before,
which affects each iteration of the telepathy-gabble tests, and makes
them take a little more than the 30 minute timeout on an i.MX6.

Double the timeout again to prevent test failures even when the tests
are making progress.

Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Reviewed-by: Luis Araujo <luis.araujo@collabora.com>
Differential Revision: https://phabricator.apertis.org/D4122

Signed-off-by: Justin Kim <justin.kim@collabora.com>

This commit explicitly adds the dbus-tests package dependency for
the dbus-dos-reply-time test definition.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4107

Even if the port is already in use, simple-httpd doesn't report and
just show a message "Waiting for requests...". It's a simple bug of
example of libsoup2.4.
Fortunately, without a specific port, simple-httpd will pick up
a port which is available. Then, we can parse its stdout to parse
running port.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D4080

Otherwise, when running check-dbus-services manually, it will
launch a pager.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3903

We fixed UserPrompter0 by moving to systemd activation.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3901

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3899

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3898

This came from the chaiwala-btrfs package, which we haven't shipped
since 15.12.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3897

T2326, aka #428, has now been fixed.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3896

Both the tracker-indexing-local-storage and apparmor-tracker tests
are currently being executed manually since they require the
/home partition properly mounted in the test image and that is not
the way LAVA boots the test image.

This is a temporary solution until LAVA can properly mount all the
available partitions in the test image.

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: Luis Araujo <luis.araujo@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3482

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3775

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3773

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3772

The Tracker services are started on-demand, while Xorg might not be
installed.

Also continue testing if one of these assertions fails: just log it
as "not OK".

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3771

We're effectively asserting that all these processes are running,
so we should look at whether they, in fact, *are* running, and
if not, why not.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3639

If we fail to read the AppArmor profile or other required information
due to a time-of-check/time-of-use difference (the process exits)
then that's fine. Otherwise, it's a problem and we should fail,
although we might as well continue testing and get more complete
results.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3770

Reviewed-by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3638

In practice, the regex should always match: AppArmor "confinement
strings" appear to always contain a label and mode, except in the
special case "unconfined". However, if this is untrue for whatever
reason, we should log it as an error, not carry on blindly.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3637

The manual test instructions at
<https://wiki.apertis.org/QA/Test_Cases/apparmor-tracker

> call for
all of these (plus python3, but that's already pulled in by
dh_python3), and the scripts used for the tests do need them.

Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3641

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

This corresponds to the change made in iptables_1.6.0-2ubuntu3co2.

Bug: https://phabricator.apertis.org/T2214



Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3767

As with many previous commits, there's no point in installing this
simple script; running it from the git directory gives us faster
fix/test cycles.

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3766

Real Apertis images have ~/Documents already, but the Documents
directory isn't created when the filesystem image is picked apart
and reassembled by LAVA. This causes `mktemp`, and hence the
apparmor-libreoffice test, to fail on LAVA.

Relevant to T2104, but does not close it.

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3765

Regression in e562c672 (D3663).

Bug: https://phabricator.apertis.org/T2215



Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3764

Our test should be using the session environment as setup by the system
(in lava specifically by run-in-systemd). So remove the hardcoding of
DISPLAY (deprecated on wayland targets anyway), XDG_RUNTIME_DIR (setup
by the environment in all cases) and DBUS_SESSION_BUS_ADDRESS (should be
inferred by XDG_RUNTIME_DIR by all supported dbus libraries)

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3664

As soon as there is a dbus user session a session bus should be
available. Only verify that this exists (failling if it doesn't) rather
then trying to workaround things by autolaunching a new bus.

Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3663

There is a session bus setup by systemd for the normal user, which is
the one all tests should use. Use that by simply running the test as
user user.

Fixes: https://phabricator.apertis.org/T1906



Reviewed-by: Luis Araujo <luis.araujo@collabora.co.uk>
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D3662

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>