Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

It’s possible for wget to finish downloading a file before being killed
by the test harness (for example, if the download is particularly fast.

These failures to kill processes don’t indicate failure of the test
case, so should be ignored.

Additionally, prevent client.py from exiting early due to its D-Bus
timeout expiring — tcmmd never sends a reply to the method call, so
client.py should not expect one. This requires ignoring the need for a
reply, and also running the dbus-python main loop correctly rather than
sleeping and potentially ignoring incoming D-Bus traffic.

Bug: https://bugs.apertis.org/show_bug.cgi?id=327
Differential Revision: https://phabricator.apertis.org/D509


Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

If the manual run-tcmmd-test fails because the user replies ‘no’ to any
of the questions, it doesn’t clean up its tcmmd process. This causes an
immediate failure of the test if it’s run again. Fix that by always
cleaning up tcmmd.

Differential Revision: https://phabricator.apertis.org/D427


Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>

Philip Withnall authored 9 years ago and Sjoerd Simons committed 9 years ago

There’s a race condition between killing a process and waiting for it to
terminate; since this test is run with `set -e`, this can cause the test
to fail if the process dies before `wait` is invoked. Fix that by
ignoring failure from it.

Bug: https://bugs.apertis.org/show_bug.cgi?id=327
Differential Revision: https://phabricator.apertis.org/D426


Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>