ci: Fix publishing to pages from default branch
ci: Fix publishing to pages from default branch
Commit 728c9142 "Use CI_DEFAULT_BRANCH as the default branch" actually
broke the publishing via GitLab pages from the default branch since
the only: [ ${CI_DEFAULT_BRANCH} ] condition was not really expanding
the variable and it was considering ${CI_DEFAULT_BRANCH} as a literal
branch name.
This means that the test-pdf job got always instantiated while pages
never was, regardless of the branch they where running on.
By switching to rules: we can properly implement automatic default
branch detection and fix the regression.
Signed-off-by: Ritesh Raj Sarraf ritesh.sarraf@collabora.com
Merge request reports
Activity
assigned to @ritesh
mentioned in merge request !617 (merged)
- Resolved by Ritesh Raj Sarraf
The commit message is quite bad tbh. It is stating the "what" and not explaining the "why". I mean, it should definitely mention that this is a fix for a regression introduced in the previous commit, but there's no indication of that.
- Last reply by Ritesh Raj Sarraf
added 2 commits
added 2 commits
requested review from @em
added 1 commit
- 7c062841 - ci: Fix publishing to pages from default branch
added 3 commits
-
7c062841...ff9ae14f - 2 commits from branch
master - 03986912 - ci: Fix publishing to pages from default branch
-
7c062841...ff9ae14f - 2 commits from branch
mentioned in merge request !621 (merged)
added 2 commits