Skip to content
Snippets Groups Projects
Commit b51a4bc9 authored by Emanuele Aina's avatar Emanuele Aina Committed by Frederic Danis
Browse files

development_process: Point to https://mtlynch.io/code-review-love/


The "How to Make Your Code Reviewer Fall in Love with You" post provide
a nice and entertaining guide on submitting changes for review.

Signed-off-by: Emanuele Aina's avatarEmanuele Aina <emanuele.aina@collabora.com>
parent 27238d58
No related branches found
No related tags found
1 merge request!130Minor tweaks related to code review in the development process page
......@@ -65,6 +65,23 @@ Clone the forked repository
## Review
* Getting changes reviewed is extremely important because it is a great way to
expand knowledge for both the submitter and the reviewer; some
[good practices for code review](https://mtlynch.io/code-review-love/) help
the process to go as smoothly as possible:
1. Review your own code first
2. Write a clear changelist description
3. Automate the easy stuff
4. Answer questions with the code itself
5. Narrowly scope changes
6. Separate functional and non-functional changes
7. Break up large changelists
8. Respond graciously to critiques
9. Be patient when your reviewer is wrong
10. Communicate your responses explicitly
11. Artfully solicit missing information
12. Award all ties to your reviewer
13. Minimize lag between rounds of review
* Notify maintainers on the devel [mailing list](https://lists.apertis.org/)
when submitting or updating a merge request.
* The repository
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment