Skip to content
Snippets Groups Projects
Commit 4dabc0b4 authored by Martyn Welch's avatar Martyn Welch Committed by Emanuele Aina
Browse files

Repair scripting failure


A mistake whilst scripting replacements resulted in lines with 3
characters being replaced and later removed. Fix these errors.

Signed-off-by: default avatarMartyn Welch <martyn.welch@collabora.com>
parent 876f30c7
No related branches found
No related tags found
1 merge request!52Wip/martyn/t7270 tweak designs
......@@ -1193,6 +1193,7 @@ appropriate for Apertis to provide API to assist in performing the task
accurately.
A minimal C language API for state saving could be developed consisting
of:
- A way to register a callback for a D-Bus signal that requests a save
of state information.
......
......@@ -243,7 +243,7 @@ such as `(nullable)`.
Pre- and post-condition assertions are implemented using
[`g_return_if_fail()`](https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#g-return-if-fail)
and
[`g_return_val_if_fail()`](https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#g-return-val-if-fail).
The pre-conditions should check each parameter at the start of the function,
......@@ -323,9 +323,11 @@ implemented using the linking pointers, rather than a incrementing index:
GList *some_list, *l;
for (l = some_list; l != NULL; l = l->next)
{
gpointer element_data = l->data;
/* Do something with @element_data. */
}
```
Using an incrementing index instead results in an exponential decrease in
......@@ -337,9 +339,11 @@ guint i;
/* This code is inefficient and should not be used in production. */
for (i = 0; i < g_list_length (some_list); i++)
{
gpointer element_data = g_list_nth_data (some_list, i);
/* Do something with @element_data. */
}
```
The performance penalty comes from `g_list_length()` and `g_list_nth_data()`
......@@ -354,9 +358,11 @@ GPtrArray *some_array;
guint i;
for (i = 0; i < some_array->len; i++)
{
gpointer element_data = some_array->pdata[i];
/* Do something with @element_data. */
}
```
## Magic values
......
......@@ -67,6 +67,8 @@ might be started by sending an email to the projects devel
[mailing list](https://lists.apertis.org/) saying:
```
Hi,
I'm attempting to use <project> to <task> for my project.
I'm thinking about doing <brief technical overview> to enable this usecase.
......
......@@ -35,6 +35,7 @@ environment.
For each Apertis release there are two relevant Jenkins jobs to build images;
The first job builds a Docker image which defines the build environment and
uploads the resulting image to the Apertis Docker registry. This is defined in
the
[apertis-docker-images git repository](https://gitlab.apertis.org/infrastructure/apertis-docker-images).
The second job defines the build steps for the various ospacks, hardware packs and
images which are run in the Docker image build by the previous job; it also
......
......@@ -2654,7 +2654,7 @@ domains must trigger the
[`NameOwnerChanged signal`](https://dbus.freedesktop.org/doc/dbus-specification.html#bus-messages-name-owner-changed)
in response to the
[`org.freedesktop.DBus.ReleaseName()`](https://dbus.freedesktop.org/doc/dbus-specification.html#bus-messages-release-name)
and
[`org.freedesktop.DBus.RequestName()`](https://dbus.freedesktop.org/doc/dbus-specification.html#bus-messages-request-name)
calls. No specific ordering is required and thus the service may be
temporarily unavailable or the two domains may export the same service
......
......@@ -129,6 +129,7 @@ This is what a typical MPL license header looks like:
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
```
For additional guidance on how license headers work, please read the
......@@ -208,6 +209,7 @@ resulting copyright header would look like:
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
```
## License for images
......
......@@ -1634,6 +1634,7 @@ they are written. This is what dconf uses for storage.
All updates to a GVDB file are atomic, as it uses the same
atomic-overwrite technique as [GKeyFile]( {{< ref "#gkeyfile" >}} ). Transactions are
supported similarly — by writing out the updated database or discarding
it.
The amount of I/O for reads from a GVDB file is small, as it memory-maps
the database, so only pages in the data it actually reads (plus some
......
......@@ -241,6 +241,7 @@ hardware features available with the storage media.
The System Updates and Rollback Design describes the partition layout
for Apertis. Not all the partitions have the same requirements, so both
the FAT32 and BTRFS filesystems are used. The partitions are configured
as:
- **Factory Recovery** – This partition is never mounted read-write
and must be readable by the boot loader. Currently the boot loader
......
......@@ -402,6 +402,7 @@ IPC mechanism. Android uses two very simple strategies to forcibly stop
an application: 1) it kills applications when the device is out of
memory; 2) it notifies the user of [unresponsive applications][Android-responsiveness] and allows
them to force the application to close, similar to how GNOME does
it.
An application is deemed to not be responding after about 5 seconds of
not being able to handle user input. This feature is implemented by the
......@@ -902,6 +903,7 @@ policy file:
```shell
$ cat /etc/apparmor.d/bin.ping
...
/bin/ping {
#include <abstractions/base>
#include <abstractions/consoles>
......
......@@ -1567,6 +1567,7 @@ if (action.id == 'org.apertis.vehicle_device_daemon.WriteProperty' &&
/* Deny all other accesses. */
return polkit.Result.NO;
});
```
In the rules, the subject is always the program in the bundle which is
......
......@@ -187,6 +187,7 @@ the best way to guarantee stability, but that will only delay the impact
of the changes. Building a set of APIs that abstract some of the
platform can also be sensible: applications using high level widgets can
be shielded from changes done at the lower levels – Clutter, Mx, and so
on.
To conclude: taking advantage of open source code takes away some of the
control over the platform's future. While Google and Apple are able to
......@@ -452,6 +453,7 @@ but work may be done on a case-by-case basis to provide a smooth
migration path, with old versions coexisting with newer ones when
possible. Most existing open source APIs related to core functionality
fall in this support level: Mx, clutter, clutter-gst, GStreamer, and so
on.
As discussed in section 3.5.1, [The GTK upgrade and a Clutter API break]( {{< ref "#the-gtk-upgrade-and-a-clutter-api-break" >}} ),
there are ways to deal with ABI/API breakage in these libraries. Keeping
......
......@@ -665,6 +665,7 @@ user interface:
{ "name": "activated", "handler": "app_activated_cb" }
]
}
]
}]
```
......@@ -711,6 +712,7 @@ chooser user interface:
{ "name": "activated", "handler": "app_activated_cb" }
]
}
]
}]
```
......@@ -831,6 +833,7 @@ reference. For example:
```
{
"id": "example-with-children",
...
"children": [
"first-child",
{
......@@ -841,6 +844,7 @@ reference. For example:
"external-uri": "file:///path/to/another.json",
"id": "third-child"
}
]
}
```
......@@ -924,6 +928,7 @@ gint item_id)
/* change animation */
} else {
/* reset animation */
}
/* chain up */
return roller_class->activate (roller, item_id);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment