In commit 2e59623a a fix to the cursor use was introduced. However, the fix
tries to overcome the issue in a wrong way.

The problem is caused by the fact that the cursor is saved before running the
test and then it is used to check newer entries of a specific type (audit).
Since when journalctl is used with -t the cursor is first moved to the first
entry of the specific type the --after-cursor was changed for --cursor to
make the test pass.

However, a better approach would be to save the cursor also taking into
account the type of entry we are interested on, so later when we use it we
can safetly check entries with --after-crusor.

The only tricky case would be if there are no previous entries of the
specific case, which will lead to an empty cursor. So also handle that case.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Using --after-cursor in combination with -t audit does produces the expected
output since the filtering logic is applied before and after that the cursor
is moved to next valid entry. In this case, using --after-cursor will cause
the output to miss the first entry in the log.

Fix the issue by using --cursor instead.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

To read the log for the currently running test only, the current
date and time is used with the `--since` argument of
journalctl.

Sometimes, tests can run too fast one after the other and the last log
entries of the previous test is at the same timestamp as the one
running.

That makes the current test parse log entries from the
previous test, which is unexpected, and the test fails.

Unfortunately, the `--since` argument of journalctl doesn't allow for
more precision than the second.

To fix that, use the current journal cursor instead of time.
With this approach, no entries from the previous test is read by the
current test

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

This will allow to create the architecture library path like
`/usr/lib/arm-linux-gnueabihf/`.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Frederic Danis authored 3 years ago and Emanuele Aina committed 3 years ago

The `test/common` repository uses `apertis/v20*` branches, not `main` or
`master`.
`common-subtree.sh` is using the current branch from the working
test repo to infer which remote branch to import: if it's not in the
`apertis/*` form, retrieve the latest branch from the `test/common`
repository.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

This script fails when LD_LIBRARY_PATH is not set before calling it and
calling script has `nounset` option set.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

New version of `csplit` from `rust-coreutils` fails with following error:
  $ csplit R1.13a.1_bluez-spp.expected -f /tmp/EXPECT -b "%d" "/^## alternative ##$/" {*}
  csplit: error: incorrect conversion specification in suffix

Replacing `%d` by `%0d` fixes it.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

We do not use "master" anymore, hence try to autodetect the proper
branch and fallback to master otherwise.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Access to system journal is restricted for user after switching to
Debian. AppArmor tests need to check system log with journalctl but
without proper permissions they fail.
Adding sudo for non-root users allows to check the log entries and
compare the output with expected.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Signed-off-by: Andre Moreira Magalhaes (andrunko) <andre.magalhaes@collabora.co.uk>

This flag causes lava to classify the test in the wrong category.

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>

Some binaries need to be copied with shared libraries.
Export LD_LIBRARY_PATH variable allows to put and use needed
libraries from `$TESTDIR/$ARCH/lib` directory.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

Tests can use it to locate architecture specific files

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>

Correct handling of missing .bash_history

See merge request common!3

README: Describe usage of common-subtree.sh

See merge request common!4

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.co.uk>

Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Add run-aa-test

See merge request !2

The script aa_log_extract_tokens.pl expects the format of the logs from
audit. As we don't have audit in the majority of our images and would like
to extract this information from the journal, remove this script and
replace with a shell function.

Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

A number of tests use the script `run-aa-test`. Add the shell port of this
script to common so that it doesn't need to be replicated in multiple
places.

This script uses `aa_log_extract_tokens.pl`, so pull that into common too.

Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>

Add more helper scripts required by tests

See merge request common!1