Commit 6ec78ba8 authored by Emanuele Aina's avatar Emanuele Aina

renderer: Show install steps on manual testcases as well

The pre-condition steps generated by the `install`/`git-repos` directives
where only rendered for automated testcases. Arguably, manual testers are
more interested in those being rendered than LAVA, which usually considers
the YAML enough as-is.

This currently affected the WebKit manual testcases such as
webkit2gtk-ac-3d-rendering.yaml where no installation pre-condition was
rendered, omitting fundamental steps needed by manual testers.
Signed-off-by: Emanuele Aina's avatarEmanuele Aina <>
parent 4c80a503
Pipeline #1593 passed with stages
in 36 seconds
......@@ -149,13 +149,16 @@ def get_template_values(testcase_data):
# If the test is automated, it should always have 'install:git-repos'
install = testcase_data.get('install')
if is_automated and install:
if install:
git_repos = install.get('git-repos', [])
git_repo_url, git_repo_branch = None, None
for gr in git_repos:
git_repo_url, git_repo_branch = gr.get('url'), gr.get('branch')
if not git_repo_url or not git_repo_branch:
print("Error: missing mandatory field git-repos:url/branch for " \
if not git_repo_url:
print("Error: missing mandatory field git-repos:url")
if is_automated and not git_repo_branch:
print("Error: missing mandatory field git-repos:branch for " \
"automated tests")
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment