- Oct 14, 2019
-
-
George Kiagiadakis authored
-
George Kiagiadakis authored
-
George Kiagiadakis authored
The alsa.pcm devices currently use "device.api" = "alsa:pcm" but then the node overrides this later to just "alsa", which is confusing. For now, let's match "alsa:pcm" in the monitor, even though this does not appear on the node later. This commit fixes device preferences in wireplumber.conf, which were broken because the alsa endpoint names were empty of info about the alsa device
-
- Oct 10, 2019
-
-
George Kiagiadakis authored
-
- Oct 07, 2019
-
-
George Kiagiadakis authored
next version is going to be 0.2 from this branch
-
George Kiagiadakis authored
This allows the bluealsa gstreamer helper to link to the speakers constantly, with both A2DP and HFP streams. If this is not enabled, only one of those will manage to connect, randomly. This is definitely something to be superseeded by proper policy management implemented with configuration files
-
George Kiagiadakis authored
This is not used by AGL anymore and it will go away *anyway* when we switch to the configuration-based logic for creating endpoints
-
George Kiagiadakis authored
This is complex and it gets in the way of forward-porting the bluez-alsa integration bits from the 0.1 branch. simple-policy will be removed anyway and replaced with the configuration-based logic that is in the works, so we will not need this code again, even if we switch back to the native pipewire bluez5 integration
-
George Kiagiadakis authored
-
George Kiagiadakis authored
In current pw master the behavior has been changed to not activate the "On" profile on alsa devices by default, because of the DeviceReserve D-Bus API implementation in media-session. This is a hack here to get the previous behavior. In the future we should have a way to configure profiles, as well as to pick a sensible default by autodetection.
-
George Kiagiadakis authored
-
- Oct 02, 2019
-
-
George Kiagiadakis authored
When the audioconvert starts, it emits 2 ports, but when we set the PortConfig, it removes them and re-creates them. Previously, the stream class would not remove the old port proxies from the list and therefore they existed twice. It is also necessary here to store the proxies earlier, when they are added, instead of when they are augmented, so that we can ensure they are removed. Previously we would hit an issue where: - port proxy is added, augmented - augment completes but the GTask wants to complete asynchronously: it stores a ref on the proxy and adds an idle source - server removes the proxy, we delete it from the core's list - the GTask now calls the augment callback, which stores the (removed) proxy on the stream's port_proxies list...
-
George Kiagiadakis authored
Running audioconvert in merge+split mode is the only way to make this work with the adapter, since the adapter does not support passing multiple channels on a single port right now, and if it does at some point, it will be without a mixing node on the port, which means we will not be able to mix multiple audioconvert nodes on the same adapter. In the future we need to consider writing a lighter volume node with multiple channels support to replace audioconvert. The new linking algorithm now takes into account the channel positions and makes sure to link the correct channels together. Also, it avoids passing the port proxies inside the GVariants, thus making the algorithm a bit more generic and easier to unit test.
-
George Kiagiadakis authored
-
George Kiagiadakis authored
This is a remainder from the old WpRemote, which is gone. I would re-add the property, but it's not worth it, since libpipewire prints it as well by default
-
- Sep 25, 2019
-
-
Julian Bouzas authored
-
Julian Bouzas authored
-
Julian Bouzas authored
-
Julian Bouzas authored
-
- Sep 22, 2019
-
-
George Kiagiadakis authored
GVariant is instructed to store a 64-bit unsigned integer (mode "t") but we pass it a pointer to a pointer to read this value out, which will crash in 32-bit architectures, as the pointer doesn't have enough bits and g_variant_lookup therefore corrupts the stack.
-
George Kiagiadakis authored
-
- Sep 17, 2019
-
-
George Kiagiadakis authored
Because the proxy_event_destroy() handler now takes a ref to the WpProxy, which is an error to do in finalize()
-
George Kiagiadakis authored
-
George Kiagiadakis authored
This is a generic WpMonitor loader that sets up the WpMonitor properties from the module arguments and applies some well-known properties to the device & node objects
-
George Kiagiadakis authored
This class wraps a SPA monitor and creates all the devices and nodes as they are being discovered
-
George Kiagiadakis authored
-
George Kiagiadakis authored
A method to copy specific keys from one properties set to another
-
George Kiagiadakis authored
-
George Kiagiadakis authored
-
George Kiagiadakis authored
This is very easy to reproduce when the pipewire-alsa integration is installed and you do 'arecord -l'; the alsa plugin connects and disconnects again before the proxy is ready. In this case we have to skip remote-global-added and we also have to be careful with the references: the global-removed callback is called earlier, so the core's reference to the proxy is gone and the GTask is the only thing holding a reference to the proxy. When we unref the GTask, the proxy is also unrefed, so we have to keep an additional reference in order to avoid crashing when accessing the hash table below.
-
- Sep 09, 2019
-
-
Julian Bouzas authored
-
- Sep 07, 2019
-
-
George Kiagiadakis authored
-
George Kiagiadakis authored
In practice we always create a remote and connect to pipewire. Any other scenario is invalid, therefore, it is not justified to be confused with so many classes for such small functionality. This simplifies a lot the modules code. Also, this commit exposes the pw_core and pw_remote objects out of WpCore. This is in practice useful when dealing with low-level pw and spa factories, which are used in the monitors. Let's not add API wrappers for everything... Bindings will never use this functionality anyway, since it depends on low level pipewire C API.
-
George Kiagiadakis authored
-
George Kiagiadakis authored
-
- Sep 05, 2019
-
-
George Kiagiadakis authored
Since the alsa endpoints class was renamed...
-
- Sep 02, 2019
-
-
Julian Bouzas authored
-
- Aug 29, 2019
-
-
George Kiagiadakis authored
-
George Kiagiadakis authored
In case the proxy was created with wp_proxy_new_wrap(), the event listener was not attached on the pw_proxy
-
George Kiagiadakis authored
-