From 403bb0643ac40e1b5c5f599fe738e0ccf5d14adb Mon Sep 17 00:00:00 2001
From: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Sat, 14 Nov 2020 13:17:45 +0200
Subject: [PATCH] impl-endpoint{,-stream}: disable FEATURE_PROPS temporarily

---
 lib/wp/endpoint-stream.c | 10 +++++-----
 lib/wp/endpoint.c        | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/wp/endpoint-stream.c b/lib/wp/endpoint-stream.c
index 1fca9958..34a855f3 100644
--- a/lib/wp/endpoint-stream.c
+++ b/lib/wp/endpoint-stream.c
@@ -450,10 +450,10 @@ wp_impl_endpoint_stream_activate_get_next_step (WpObject * object,
         WP_SESSION_ITEM (self->item), WP_TYPE_NODE);
 
     /* if the item has a node, cache its props so that enum_params works */
-    if (node && !(wp_object_get_active_features (node) &
-                      WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS))
-      return STEP_ACTIVATE_NODE;
-    else
+    // if (node && !(wp_object_get_active_features (node) &
+    //                   WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS))
+    //   return STEP_ACTIVATE_NODE;
+    // else
       return WP_PIPEWIRE_OBJECT_MIXIN_STEP_BIND;
   }
   /* cache info if supported */
@@ -490,7 +490,7 @@ wp_impl_endpoint_stream_activate_execute_step (WpObject * object,
         WP_SESSION_ITEM (self->item), WP_TYPE_NODE);
 
     wp_object_activate (node,
-        WP_PROXY_FEATURE_BOUND | WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS,
+        WP_PROXY_FEATURE_BOUND /*| WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS */,
         NULL, (GAsyncReadyCallback) wp_impl_endpoint_stream_node_activated,
         transition);
     break;
diff --git a/lib/wp/endpoint.c b/lib/wp/endpoint.c
index 667a4279..6a495f48 100644
--- a/lib/wp/endpoint.c
+++ b/lib/wp/endpoint.c
@@ -966,10 +966,10 @@ wp_impl_endpoint_activate_get_next_step (WpObject * object,
         WP_SESSION_ITEM (self->item), WP_TYPE_NODE);
 
     /* if the item has a node, cache its props so that enum_params works */
-    if (node && !(wp_object_get_active_features (node) &
-                      WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS))
-      return STEP_ACTIVATE_NODE;
-    else
+    // if (node && !(wp_object_get_active_features (node) &
+    //                   WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS))
+    //   return STEP_ACTIVATE_NODE;
+    // else
       return WP_PIPEWIRE_OBJECT_MIXIN_STEP_BIND;
   }
   /* enable FEATURE_STREAMS when there is nothing else left to activate */
@@ -1008,7 +1008,7 @@ wp_impl_endpoint_activate_execute_step (WpObject * object,
         WP_SESSION_ITEM (self->item), WP_TYPE_NODE);
 
     wp_object_activate (node,
-        WP_PROXY_FEATURE_BOUND | WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS,
+        WP_PROXY_FEATURE_BOUND /*| WP_PIPEWIRE_OBJECT_FEATURE_PARAM_PROPS */,
         NULL, (GAsyncReadyCallback) wp_impl_endpoint_node_activated,
         transition);
     break;
-- 
GitLab