ribchesterctl command line tool is being used for bundle handling
like install/uninstall/update and it is shipped along with the
ribchester package.

Signed-off-by: Thushara Malali Somesha <ThusharaM.MalaliSomesha@in.bosch.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5384

Signed-off-by: Justin Kim <justin.kim@collabora.com>

Prepared man pages are packed into `.deb`.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5365

`subprocess.PIPE` returns a bytes object which has no attribute
`read`.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5358

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

When we only want the GDB server running

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5328

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

We were trying to connect the GDB client even before we got the
listening event. The debugger server thread is now looping forever.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5327

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

If the --app is not given, we check the installed desktop files
and use the main one if that makes sense.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5326

There is no reason to not allow e.g. an ssh agent or to prevent ade
looking for keys, so drop the restrictions. Also fixes launching the
install job from eclipse as that doesn't seems to pass a user and relies
on ssh key authentication.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D5344

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D5343

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

If ade execv's gdb then its process will be replaced, potentially
causing the ssh connection to the target device to fail which will kill
the remote gdb server. So instead run gdb in a subprocess, keeping ade
(and thus the ssh connection) alive during the debugging session.

Also instead of using gdb, use gdb-multiarch which is a variant capable
of interacting with gdbservers of multiple architectures (and
understand/parsing the debug symbols of multiple architectures). This
means it can be used to debug both ARM and Intel targets, rather then
just native targets.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5305

debug-file-directory is the directory where gdb goes to look for
detached debug symbols (the non buildid kind). It's interaction with the
sysroot bits are bit.. odd.. For each debug-file-directory path it will
look in ${path}/${sysroot}/<debuglink> and ${path}/debuglink, both of
which are mostly useless  for sysroots.

Explicitely set the path to ${sysroot}/usr/lib/debug to set gdb
straight.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5304

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Start the gdbserver on device and start gdb client locally in interactive
mode. Default port is not configurable as of now (1234) and other targets
(e.g. simulator, SDK) are not supported.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5299

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

If the target is a device, we want to know whether to use a
sysroot or the SDK for configuration/debugging/etc.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5298

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

ARGS options are for the application getting started

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5297

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

The target.run() function expects to receive the arguments
unpacked.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5287

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

If sysroot is None, it means we want to compile natively (e.g.
for the simulator or for a target device with the same arch)

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5286

Justin Kim authored 8 years ago and Sjoerd Simons committed 8 years ago

`ade` uses paramiko module.

Signed-off-by: Justin Kim <justin.kim@collabora.com>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5278

 * Directory for apps is Applications not Application
 * Don't set --sysconfdir so the AppArmor profile is in the
   right directory

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5280

ribchester-bundle is a python3-gi based application which is capable of
doing some low-level operations in ribchester, ribchesterctl is a
simpler C application installed as part of the ribchester package which
can at the moment only do install and remove (which is exectly what ade
is doing).

Move ade to use ribchestectl so it doesn't need anything not normally
installed on a target device. Also for operation on a target device use
sudo (an ssh user is not allowed to install applications).

While there, also copy bundles to /tmp rather then hardcode the users
home directory (which could change in the future).

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Differential Revision: https://phabricator.apertis.org/D5261

ade install failed for me as my target device doesn't have
ribchester-bundle, however it did so without giving any indication
something was wrong at all.

Sort this out by raising an exception if the remote command returns a
non-zero exit status.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

Differential Revision: https://phabricator.apertis.org/D5260

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>

Differential Revision: https://phabricator.apertis.org/D5233

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>

Differential Revision: https://phabricator.apertis.org/D5232

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>

Differential Revision: https://phabricator.apertis.org/D5231

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>

Differential Revision: https://phabricator.apertis.org/D5230

Louis-Francis Ratté-Boulianne authored 8 years ago and Sjoerd Simons committed 8 years ago

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>

Differential Revision: https://phabricator.apertis.org/D5245

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5258

Unless a compiler which produces code for the target is setup, the
result of the compilation (if successful) will just be native code which
isn't helpful. Setup target specific gcc && linker instead

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5257

The intention here is to point to the /usr/include in the sysroot,
however when joining an absolute paths the result will just be the last
absolute paths

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5256

We're using four different ways to define the achitecture. There is the
machine name as given by e.g. uname -m, the dpkg architectures (armhf,
amd64, etc) and finally the gnu arch triplet (e.g. aarch64-linux-gnu).
Have TargetTriplet recognize all three and properties for all three
variants.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5253

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5252

When the keyfile passed to paramiko doesn't exist connecting to the
remote device will fail, to fix that simply remove it. Specifying it has
very little value given paramiko should search for private keys in .ssh
by default.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5251

Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5254

Due to a previous bug in the makefiles, debhelper didn't actually
install anything relevant (as the install target bailed even during a
dry-run). Prevent this from happening again by being very specific about
what gets installed and fail the package build process in case of
unexpected files.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5250

The parent makefile will recursively call all submakefiles for various
targets among which install. So this makefile needs to handle that even
if it doesn't do anything

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5249

Add a tmpfile snippet to create the /opt/sysroot directory. Owned by
root:staff and group writable such that the default user can write to
it, making ade sysroot install usable as a user directly without
requiring sudo.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D5248