Signed-off-by: Andrew Lee (李健秋) <ajqlee@debian.org>

Ritesh Raj Sarraf authored 5 years ago and Emanuele Aina committed 5 years ago

Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>

When no .netrc file is found, ade resorts to priting an error message.
This can be annoying when users want to use a remote server that doesn't
need auth.

This change demotes the error message to be displayed only in
verbose mode

Closes: https://phabricator.apertis.org/T6301



Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

urllib.parse.unquote() request a string as first parameter.
Check that parsed_url.password exists before calling it.

Fixes: APERTIS-5756

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Passwords could be having special characters, in which case they need to
be percent encoded as per the RFC-3986 section 2.1. in the URL.

For such fields, where the password may be percent encoded, it also
needs to be decoded. That is what this change does. It takes the
password which may be percent encoded and provides with an ascii
equivalent string

Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

If username and password are not passed on command line, nor in url, try
to find them from .netrc file.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

urllib does not support to set the username and password in the URL.
The URL needs to be parsed to extract them before calling urlopen or
urlretrieve.
The username and password found in the URL are used unless they are
already set on command line.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

At the moment `ade` enforces a NN.NN versioning schema for sysroot with N
strictly being a digit.

Now that we switched to release versions like v2019dev0, v2019pre, v2019.0 this
is no longer appropriate.

Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Apertis: T5626

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Use bold font for subcommands and options, italics for variables
and values.

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

A gdbserver may be running left over from a previous debug session.
It will still be listening on the TCP port, preventing a new instance
from starting, so we need to kill it.

However, if we allocate a PTY when spawning it, it will die once the
session ends.

For some reason, with get_pty=True, the gdbserver’s output is coming
from stdout, not stderr.

Apertis: T4463

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

The test-export script tests the `ade export` command.
It creates an install target in moc/Makefile.in and uses it to
simulate ade's export command, which further bundles the installed files
The script then unpacks the created bundle and verified the sample file
that was bundled through `ade export`

Currently, we do it the crude way to extract the file from the bundle
because ostree/flatpak doesn't have a cleaner implementation
For details, see: https://github.com/flatpak/flatpak/issues/126



Signed-off-by: Ritesh Raj Sarraf <ritesh.sarraf@collabora.com>
Reviewed-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7914

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7435

When the debugger thread starts, it spawns a gdbserver and
waits forever. Use the Channel from paramiko to monitor the process
return value and quit when it's terminated.
Discard any output from gdbserver as it can stall the ssh link in extreme
cases.
Additionnaly "while True: pass" loops are busy loops. Relax those.
Do that for non-interactive ade too.

Apertis: https://phabricator.apertis.org/T4462



Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7431

Signed-off-by: Frédéric Dalleau <frederic.dalleau@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D7430

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>

sysroot tarball packs `./etc/image_version`, ade fails
to identify it as `etc/image_version`, therefore, we
need to append `./` to the file path.

Signed-off-by: Héctor Orón Martínez <hector.oron@collabora.co.uk>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.com>
Differential Revision: https://phabricator.apertis.org/D7384

Signed-off-by: Simon McVittie <smcv@collabora.com>

It is normal and expected for agent entry points to not have an icon.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6858

`ade configure` and `ade build` have `--native` option, but `install`
and `uninstall` commands doesn't. To install/uninstall a bundle which
is built with `--native`, user should use `ade install --simulator`
because two options actually do same thing.
For the consistency, the option, `--native`, is added.

Reviewed-by: Emanuele Aina <emanuele.aina@collabora.co.uk>
Signed-off-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6807

Signed-off-by: Simon McVittie <smcv@collabora.com>

When unparsed arguments were picked out, they were appended
to args. This is problematic if the wrapped command takes
command-line options with values of the form "--foo bar" (as
opposed to --foo=bar), because they would be re-ordered to "bar --foo",
likely causing a syntax error. It is obviously also a problem if
order is significant for the wrapped command. Prepend the unparsed
arguments to args instead of appending.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6798

Picking out the known arguments and leaving unknown arguments is
dangerous, because typos and prefix-matching can have unintended
results. To discourage this, warn if any unknown arguments were
found. These are all considered correct, and are equivalent
(except for order):

    ade configure --native -- VARIABLE=1 --with-option
    ade configure --native VARIABLE=1 --with-option
    ade configure --native -- --with-option VARIABLE=1

but this will now provoke a warning for --with-option:

    ade configure --native --with-option VARIABLE=1

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6797

The common convention of passing "--" as a separator between
arguments for this command and arguments for the wrapped command
did not work, because it would also pass the "--" through. For
instance, "ade configure --native -- --device=foo" should pass
"--device=foo" to the configure script instead of interpreting it
as ade's own --device option.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6796

Subcommands with no REMAINING arguments, such as "ade uninstall",
would previously accept and ignore unknown arguments. This could be
very bad if the command is something like "ade uninstall --dry-run".

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: André Magalhães <andre.magalhaes@collabora.co.uk>
Differential Revision: https://phabricator.apertis.org/D6795

Because we set args to a new value, any arguments passed to
"ade configure" were ignored.

Apertis: https://phabricator.apertis.org/T3978



Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6774

Python arguments are passed by reference, so if we append to these
arrays, the caller's copy of the list is modified. This seems unlikely
to be intended.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Justin Kim <justin.kim@collabora.com>
Differential Revision: https://phabricator.apertis.org/D6773