Signed-off-by: Andre Moreira Magalhaes <andre.magalhaes@collabora.com>

These variables are no longer needed after commit cda35693



Signed-off-by: Andre Moreira Magalhaes <andre.magalhaes@collabora.com>

Note this also changes the "Submit Manual Test Report" button from a link
with a "button" role to having an actual button as child of the link.
This is needed because disabling only a link with a "button" role won't change
the button style as desired.

Signed-off-by: Andre Moreira Magalhaes <andre.magalhaes@collabora.com>

Signed-off-by: Andre Moreira Magalhaes <andre.magalhaes@collabora.com>

Separate auth groups permissions can be configured to distinguish whether
logged in users can submit reports and tag images.

Note that this keeps current behaviour to only allow users to login if the user
belongs to a configured auth-group, as well as to always allow users to view results
and testcases if the always-require-login config option is disabled.

If an user tries to login and doesn't belong to any of the configured auth groups,
the login will fail and the user will be redirected to the login page.

Attempting to send a POST request to the endpoints used to submit reports
and/or tag images will fail with 403 (Forbidden) if the user doesn't belong to any
configured auth group that has the corresponding extra permissions.

Note that an empty configuration (default) for the auth-groups means that any user
with the right credentials can login and also submit reports and tag images.

Signed-off-by: Andre Moreira Magalhaes <andre.magal...

After commit 80c00c5c

 the main page shows results grouped by release,
changing the previous sort order by build. Sort by build is preferable
to easily see the status of last builds for all the supported releases
and also aligns with how results are sorted in the full page.

Fix the issue by sorting the results by build.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Detlev Casanova authored Dec 07, 2022 and Andre Moreira Magalhaes committed Dec 07, 2022

In commit 80c00c5c


("Only display the configured number of results"), a min_version field
was added to set the minimum version of the results to show.

This field was limited to a series value (v2021 was allowed but not
v2022pre).

This commit changes that so that any version value can be used.
This removes the filtering in the SQL query and moves it to
post-filtering with the `packages` python module.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Walter Lozano authored Nov 29, 2022 and Andre Moreira Magalhaes committed Dec 06, 2022

Improve README with steps to test bug tracking system.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The visual tests now have a `display` field added to the configuration.

This changes the index-page screenshot, where only the latest results
are shown according to the configuration.

Also add a test for the "Show all" page, that actually shows the same
page as index did before the display feature was added.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

This applies the configured `display` field to show only the latest
results on the main page.

An extra route is added to show all results by ignoring the configured
`display` field.

The `{{ url }}` entries are dropped in the index template to make sure
the link is not appended to "<server>/all.html" on the "Show all" page.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

The display field is used to specify what needs to be displayed on the
home page.

```
display:
  min-version: 'v2021'
  series-results:
    dailies: 4
    releases: 2
    weeklies: 3
```

That configuration will be used to only show results for v2021 and
newer.

It will also limit the number of results for each series to be
displayed. E.g.: For the releases,
 * v2023pre+v2023dev3 (last 2 release results in the v2023 series)
 * v2022.2+v2022.1
 * v2021.6+v2021.5

The same principle will be applied to the dailies and weeklies.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Currently the default value for lava-callback-tokens is misleading, since
it looks like a valid token. Change it to avoid confusions and to be
aligned with the value used in test data.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Fix the support of skipping bug tracking system for development testings.
Before this fix, QA Report App was not able to process LAVA callbacks
during local testing.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

Report generation expects a Phabricator object, causing the report to fail
if the bug tracking system is configured to use Gitlab. To fix the problem,
use the already available TestTask class to hold all the required
information. This also improves performance since it reduces the queries to
the bug tracking system.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

It is possible that LAVA job provides invalid metadata, which will make
the issue submission to fail when trying to load addtional data. To avoid
the problem use default values if the test case is not found.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

The testcases_table object is created and updated in webhook module but need
in other modules as well. In order to use the latest values in the object, pass
it as argument to the other modules.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>

dailies are not starred. weeklies are starred with
tag_type = weekly and releases are starred with
tag_type = release. Modify the logic to add counters
based on this.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Test counters information is added to the test
report page. So regenerate the screenshots.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Currently, the QA report app shows a summary of the reports
in the main page as well as detailed reports in separate
pages. However, while the summary in the main page shows
detailed counters on the number of tests executed for a
given image/build, the detailed report page only shows the
number of test cases available for that image type and the
detailed test counters information is missing.

The QA report is updated to have the same counters displayed
in the main page and in the detailed report page for a given
image/build, so that it is easy to verify the test counters
from the test report page as well.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>

Bring different visibility improvements to tagging buttons:
 - Make them the same size
 - Use capital letters (Tag instead of tag)
 - Make buttons red when they are used to untag a release
 - Add some space between the buttons

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Adding a column as non-nullable, even with a default value is not
allowed.

The process is now to add the column as nullable, edit all entries to
set the default value and then, to set the column as non-nullable.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Adding a column as non-nullable, even with a default value is not
allowed.

The process is now to add the column as nullable, edit all entries to
set the default value and then, to set the column as non-nullable.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Because the IoT LAVA tests are set to have limited visibility, the
platforms are all -internal, not -public.

https://phabricator.apertis.org/T8949



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

https://phabricator.apertis.org/T8949



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

Ryan Gonzalez authored Oct 28, 2022 and Andre Moreira Magalhaes committed Nov 01, 2022

Now that the application is hosted elsewhere, we need to update these
directions.

https://phabricator.apertis.org/T8774



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

https://phabricator.apertis.org/T8774



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

Now that the tests are run with authentication disabled, the screenshots
change:
* index-page.png shows a "Logged in as Local Session" instead of showing
  the Login button
* report-*.png now show an active "tag release" button.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

The new login requested configuration requires to use a session even if
loggin is not active or used.

To be able to use session in flask, a secret key must be set in the app.

This also set authentication_disabled to True as there is no openid
configuration in the tests.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

This option, when used, will force a user to be logged in to access any
page.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

This makes it easier to have a centralized check if the user is logged
in or not.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

https://phabricator.apertis.org/T8774



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

https://phabricator.apertis.org/T8774



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>

Now that the database config was moved to its own class in
c78cafa5, it makes sense for the URI
property to be there too.

https://phabricator.apertis.org/T9067



Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>