1. 05 Feb, 2014 4 commits
  2. 04 Feb, 2014 1 commit
  3. 03 Feb, 2014 6 commits
  4. 29 Jan, 2014 29 commits
    • mitz@apple.com's avatar
      Fixed the iOS build. · 9b465df5
      mitz@apple.com authored
      * bindings/js/JSDOMWindowCustom.cpp: Updated for header renames.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b465df5
    • ap@apple.com's avatar
      Add a WebCrypto test to verify that BigInteger allows for leading zeroes · cb2a617e
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127804
      
      Reviewed by Darin Adler.
      
      This already worked, but wasn't tested for.
      
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt: Added.
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb2a617e
    • ossy@webkit.org's avatar
      Remove ENABLE(JAVASCRIPT_DEBUGGER) guards · 1c319150
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127840
      
      Reviewed by Mark Lam.
      
      .:
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      * inspector/scripts/CodeGeneratorInspector.py:
      
      Source/WebCore:
      
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::supportsProfiling):
      (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
      * bindings/js/PageScriptDebugServer.cpp:
      * bindings/js/PageScriptDebugServer.h:
      * bindings/js/ScriptProfile.cpp:
      * bindings/js/ScriptProfile.h:
      * bindings/js/ScriptProfileNode.h:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptProfiler.h:
      * bindings/js/WorkerScriptDebugServer.cpp:
      * bindings/js/WorkerScriptDebugServer.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::resume):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      (WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
      (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
      (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
      (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
      (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
      (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
      (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
      (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
      (WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSPImpl):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      (WebCore::InspectorInstrumentation::profilerEnabledImpl):
      (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
      (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
      (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InstrumentingAgents.cpp:
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      (WebCore::InstrumentingAgents::reset):
      * inspector/InstrumentingAgents.h:
      * inspector/PageDebuggerAgent.cpp:
      * inspector/PageDebuggerAgent.h:
      * inspector/ScriptProfile.idl:
      * inspector/ScriptProfileNode.idl:
      * inspector/WebDebuggerAgent.cpp:
      * inspector/WebDebuggerAgent.h:
      * inspector/WorkerDebuggerAgent.cpp:
      * inspector/WorkerDebuggerAgent.h:
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::resume):
      * inspector/WorkerInspectorController.h:
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::pauseWorkerGlobalScope):
      * inspector/WorkerRuntimeAgent.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      * page/Console.cpp:
      * page/Console.h:
      * page/Console.idl:
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::connectToWorkerGlobalScopeInspectorTask):
      (WebCore::WorkerMessagingProxy::connectToInspector):
      (WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
      (WebCore::WorkerMessagingProxy::disconnectFromInspector):
      (WebCore::dispatchOnInspectorBackendTask):
      (WebCore::WorkerMessagingProxy::sendMessageToInspector):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_set_property):
      (webkit_web_inspector_get_property):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::startJavaScriptDebugging):
      (WebKit::WebInspector::stopJavaScriptDebugging):
      (WebKit::WebInspector::setJavaScriptProfilingEnabled):
      (WebKit::WebInspector::startJavaScriptProfiling):
      (WebKit::WebInspector::stopJavaScriptProfiling):
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c319150
    • eric.carlson@apple.com's avatar
      [iOS] cleanup MediaPlayer.cpp · f815734f
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127821
      
      Reviewed by Jer Noble.
      
      Don't register MediaPlayerPrivateIOS unless the runtime setting for media player proxy is set.
      
      * platform/graphics/MediaPlayer.cpp: Don't define PlatformMediaEngineClassName on iOS
      (WebCore::installedMediaEngines): Drive by cleanup to return early if registration has
          already happened.
      (WebCore::MediaPlayer::MediaPlayer): Don't force-register the first media engine unless
          isVideoPluginProxyEnabled returns true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f815734f
    • commit-queue@webkit.org's avatar
      Source/WebCore: Have XHR.getResponseHeader() return null and... · 9deb505f
      commit-queue@webkit.org authored
      Source/WebCore: Have XHR.getResponseHeader() return null and XHR.getAllResponseHeader() return the empty string in initial ready states
      https://bugs.webkit.org/show_bug.cgi?id=125840
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-29
      Reviewed by Alexey Proskuryakov.
      
      Merging https://chromium.googlesource.com/chromium/blink/+/d201caf874a0bd6f101f517462b3cf1d8c5fce3d
      This patch makes it clear that null/empty string is returned whenever the error flag is set.
      This new code path is covered by the added test.
      
      Test: http/tests/xmlhttprequest/response-access-on-error.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::getAllResponseHeaders):
      (WebCore::XMLHttpRequest::getResponseHeader):
      * xml/XMLHttpRequest.h:
      * xml/XMLHttpRequest.idl:
      
      LayoutTests: Have XHR.getResponseHeader() return null and XHR.getAllResponseHeaders() return empty string in initial ready states
      https://bugs.webkit.org/show_bug.cgi?id=125840
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-29
      Reviewed by Alexey Proskuryakov.
      
      Merging https://chromium.googlesource.com/chromium/blink/+/d201caf874a0bd6f101f517462b3cf1d8c5fce3d
      The new test exercices the new code path in case xhr received HTTP headers but m_error is set
      
      * http/tests/xmlhttprequest/getAllResponseHeaders-expected.txt:
      * http/tests/xmlhttprequest/getAllResponseHeaders.html:
      * http/tests/xmlhttprequest/getResponseHeader-expected.txt:
      * http/tests/xmlhttprequest/getResponseHeader.html:
      * http/tests/xmlhttprequest/response-access-on-error-expected.txt: Added.
      * http/tests/xmlhttprequest/response-access-on-error.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9deb505f
    • antti@apple.com's avatar
      REGRESSION (r162947): Repaint test results are different between WK1 and WK2 · 3957e401
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127814
      
      Source/WebCore: 
      
      Reviewed by Anders Carlsson.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::repaintContentRectangle):
              
          Move repaint rect logging to RenderView.
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::repaintViewRectangle):
              
          Record raw repaint rects instead of optimized ones.
      
      LayoutTests: 
      
      Revert test results changes. We now always log raw repaint rects which are same between platforms.
      
      * compositing/repaint/resize-repaint-expected.txt:
      * fast/box-shadow/shadow-repaint-expected.txt:
      * fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
      * fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
      * fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
      * fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
      * fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt:
      * fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt:
      * fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt:
      * fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt:
      * fast/regions/repaint/invalid-region-repaint-crash-expected.txt:
      * fast/regions/repaint/repaint-element-inside-relative-region-expected.txt:
      * fast/regions/repaint/repaint-regions-overflow-expected.txt:
      * fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
      * fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
      * fast/repaint/horizontal-bt-overflow-child-expected.txt:
      * fast/repaint/horizontal-bt-overflow-parent-expected.txt:
      * fast/repaint/horizontal-bt-overflow-same-expected.txt:
      * fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt:
      * fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
      * fast/repaint/reflection-table-layout-expected.txt:
      * fast/repaint/transform-table-layout-expected.txt:
      * fast/repaint/vertical-overflow-child-expected.txt:
      * fast/repaint/vertical-overflow-parent-expected.txt:
      * fast/repaint/vertical-overflow-same-expected.txt:
      * platform/mac-wk2/TestExpectations:
      * platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
      * platform/mac/fast/images/repaint-subrect-grid-expected.txt:
      * svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3957e401
    • beidson@apple.com's avatar
      IDB: Serialize IDBKeyDatas to disk, not IDBKeys · fbba7563
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127829
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Move encode/decode from IDBKey to IDBKeyData.
      
      * Modules/indexeddb/IDBKey.cpp:
      * Modules/indexeddb/IDBKey.h:
      
      * Modules/indexeddb/IDBKeyData.cpp:
      (WebCore::IDBKeyData::IDBKeyData):
      (WebCore::IDBKeyData::encode):
      (WebCore::IDBKeyData::decode):
      * Modules/indexeddb/IDBKeyData.h:
      
      * WebCore.exp.in:
      
      Source/WebKit2:
      
      Serialize IDBKeyDatas, not IDBKeys.
      
      * DatabaseProcess/IndexedDB/IDBSerialization.cpp:
      (WebKit::deserializeIDBKeyPath):
      (WebKit::serializeIDBKeyData):
      * DatabaseProcess/IndexedDB/IDBSerialization.h:
      
      * DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbba7563
    • antti@apple.com's avatar
      REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and... · d1fe1050
      antti@apple.com authored
      REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out
      https://bugs.webkit.org/show_bug.cgi?id=127809
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      These tests generate very large number of small repaint rectangles that overwhelm the region code.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::repaintContentRectangle):
      * platform/graphics/Region.h:
      (WebCore::Region::gridSize):
      (WebCore::Region::Shape::gridSize):
              
          Add accessor for getting the current region grid complexity.
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::repaintViewRectangle):
              
          If the region gets very complex merge the repaint rects into a single big rectangle.
      
      LayoutTests: 
      
      * platform/mac/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1fe1050
    • stavila@adobe.com's avatar
      [CSSRegions] Unable to scroll a scrollable container for regions using mouse wheel · 49a5584d
      stavila@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123886
      
      Source/WebCore:
      
      When an element flowed into a scrollable region is scrolled using the mouse wheel, the event
      needs to be propagated to the region containing that element, on top of which the cursor
      is located.
      
      Reviewed by Antti Koivisto.
      
      Tests: fast/regions/wheel-scroll-abspos.html
             fast/regions/wheel-scroll.html
      
      * page/EventHandler.cpp:
      (WebCore::scrollNode):
      (WebCore::EventHandler::defaultWheelEventHandler):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::scroll):
      (WebCore::RenderBox::scrollWithWheelEventLocation):
      * rendering/RenderBox.h:
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::regionFromAbsolutePointAndBox):
      * rendering/RenderFlowThread.h:
      
      LayoutTests:
      
      Added tests for scrolling elements flowed into scrollable regions.
      
      Reviewed by Antti Koivisto.
      
      * fast/regions/wheel-scroll-abspos-expected.html: Added.
      * fast/regions/wheel-scroll-abspos.html: Added.
      * fast/regions/wheel-scroll-expected.html: Added.
      * fast/regions/wheel-scroll.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a5584d
    • carlosgc@webkit.org's avatar
      REGRESSION(r162922): [SOUP] Several tests are failing in EFL and GTK+ after r162922 · 391c898e
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127836
      
      Reviewed by Gustavo Noronha Silva.
      
      The problem is that I assumed that several things done in
      ResourceRequest::soupURI() were always desired, so I moved them to
      URL. This patch restores the previous behaviour, so that those
      tings are only done right before making a request.
      
      * platform/network/soup/ResourceRequestSoup.cpp:
      (WebCore::ResourceRequest::createSoupURI):
      * platform/soup/URLSoup.cpp:
      (WebCore::URL::createSoupURI):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      391c898e
    • k.czech@samsung.com's avatar
      [EFL][WK2] REGRESSION (r162586-r162589): accessibility/range-alter-by-percent.html failing · d0ae24ee
      k.czech@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127724
      
      Unreviewed EFL gardening. Passes after r162932.
      
      * platform/efl/TestExpectations: Test is no longer failing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0ae24ee
    • commit-queue@webkit.org's avatar
      Web Inspector: [REGRESSION(r162931)] Tab navigation broken in DataGrid · d2347a2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127816
      
      Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-01-29
      Reviewed by Timothy Hatcher.
      
      * UserInterface/DataGrid.js:
      (WebInspector.DataGrid.prototype.moveToNextIfNeeded):
      (WebInspector.DataGrid.prototype._editingCommitted):
      Change columnIdentifier values 0 and 1 to strings "0" and "1".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2347a2f
    • k.czech@samsung.com's avatar
      [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY · 7e9868ea
      k.czech@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121684
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Exposed aria-describedby by ATK_RELATION_DESCRIBED_BY.
      Moved elementsFromAttribut to AccessibilityObject to have common interface
      for AccessibilityNodeObject and AccessibilityRenderObject. Implemented
      supportsARIADescribedBy and ariaDescribedByElements to better deal with aria-describedby attribute.
      
      No new tests. Covered by existed one.
      
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityNodeObject.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::elementsFromAttribute):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::supportsARIADescribedBy):
      (WebCore::AccessibilityObject::ariaDescribedByElements):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::supportsARIADescribedBy):
      (WebCore::AccessibilityRenderObject::ariaDescribedByElements):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (setAtkRelationSetFromCoreObject):
      
      Tools:
      
      Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::helpText):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::helpText):
      
      LayoutTests:
      
      Slightly extended test so that it could test aria-describedby with multiple id references.
      
      * accessibility/aria-describedby-on-input-expected.txt:
      * accessibility/aria-describedby-on-input.html:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e9868ea
    • svillar@igalia.com's avatar
      [CSS Grid Layout] minmax() should be a CSSFunction instead of a CSSValueList · 04fb19cc
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127057
      
      Source/WebCore:
      
      Reviewed by Antti Koivisto.
      
      We were incorrectly dumping minmax(x,y) as "x y" instead of
      "minmax(x,y)". That's because we were treating minmax() internally
      as a CSSValueList instead of a CSSFunction. Replaced that and also
      added some extra information to our tests in order to check that
      we don't regress. From now on the CSS grid layout testing helper
      functions print not only the computed style but also the contents
      of element.style.webkitGridDefinition{Columns|Rows}.
      
      * css/CSSFunctionValue.h:
      (WebCore::CSSFunctionValue::arguments):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseGridTrackList):
      (WebCore::CSSParser::parseGridTrackRepeatFunction):
      (WebCore::CSSParser::parseGridTrackSize):
      * css/CSSParser.h:
      * css/StyleResolver.cpp:
      (WebCore::createGridTrackSize):
      
      LayoutTests:
      
      Include the output of element.style.webkitGridDefinition{Columns|Rows}
      as part of the expected output.
      
      * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
      * fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
      * fast/css-grid-layout/named-grid-line-get-set-expected.txt:
      * fast/css-grid-layout/named-grid-line-get-set.html:
      * fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
      (testGridDefinitionsSetJSValues):
      (testNonGridDefinitionsSetJSValues):
      (checkGridDefinitionsSetJSValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04fb19cc
    • rniwa@webkit.org's avatar
      Rename notifyRendererOfSelectionChange · 00163751
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127831
      
      Reviewed by Antti Koivisto.
      
      Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl.
      
      * WebCore.order: Removed the exported symbol name as it's not used in WebKit or WebKit2 code.
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::setSelection):
      (WebCore::FrameSelection::selectAll):
      (WebCore::FrameSelection::updateSelectionCachesIfSelectionIsInsideTextFormControl): Don't update the style since the existence
      of text form control's shadow DOM no longer depends on renderer.
      * editing/FrameSelection.h:
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::selectionChanged): Don't check renderer() for the same reason.
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseReleaseEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00163751
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ build after r162981. · f6227f29
      carlosgc@webkit.org authored
      * GNUmakefile.list.am: Add WebProcess/WebPage/WebDocumentLoader to
      the compilation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6227f29
    • carlosgc@webkit.org's avatar
      Unreviewed. Actually fix the GTK+ build after r162967. · d0399823
      carlosgc@webkit.org authored
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkit_web_view_can_go_back):
      (webkit_web_view_can_go_forward):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0399823
    • jinwoo7.song@samsung.com's avatar
      Unreviewed EFL gardening after r162972. · dfa9347a
      jinwoo7.song@samsung.com authored
      * platform/efl/fast/table/quote-text-around-iframe-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfa9347a
    • zandobersek@gmail.com's avatar
      Unreviewed followup to r163006. That change incorrectly modified · a61c61a3
      zandobersek@gmail.com authored
      webkit_web_view_go_forward when webkit_web_view_can_go_forward needed fixing.
      
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkit_web_view_go_forward):
      (webkit_web_view_can_go_forward):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a61c61a3
    • mmaxfield@apple.com's avatar
      Rebaseline quote-text-around-iframe.html after r162972 · 95afe815
      mmaxfield@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127822
      
      Reviewed by Alexey Proskuryakov.
      
      Forgot to rebaseline fast/table/quote-text-around-iframe.html
      
      * platform/mac/fast/table/quote-text-around-iframe-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95afe815
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix after r162967. · 7fa05284
      zandobersek@gmail.com authored
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkit_web_view_can_go_back):
      (webkit_web_view_go_forward):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa05284
    • jinwoo7.song@samsung.com's avatar
      Unreviewed EFL gardening after r162972. · 95cfba0a
      jinwoo7.song@samsung.com authored
      * platform/efl/fast/css-generated-content/005-expected.txt:
      * platform/efl/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
      * platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
      * platform/efl/fast/css-generated-content/no-openclose-quote-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95cfba0a
    • timothy_horton@apple.com's avatar
      Crashes in ViewGestureController::wheelEventWasNotHandledByWebCore · e78fa456
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127828
      <rdar://problem/15932902>
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _wheelEventWasNotHandledByWebCore:]):
      Null check. ViewGestureController only needs unhandled wheel events after it has been created.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e78fa456
    • timothy_horton@apple.com's avatar
      Fix the Mountain Lion build if you have private headers. · fadb69bb
      timothy_horton@apple.com authored
      * UIProcess/mac/ViewGestureController.mm:
      (WebKit::ViewGestureController::beginSwipeGesture):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fadb69bb
    • commit-queue@webkit.org's avatar
      [iOS] UI process crashes whenever web process crashes · 260788cd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127826
      
      Patch by Ian Henderson <ianh@apple.com> on 2014-01-28
      Reviewed by Tim Horton.
      
      * UIProcess/API/ios/WKContentView.mm:
      (-[WKContentView _updateFixedPositionRect]): Null-check the drawing
      area before calling size() on it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      260788cd
    • commit-queue@webkit.org's avatar
      WKRemoteObjectCoder should support more argument types · a94b7bcf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127824
      
      Patch by Ian Henderson <ianh@apple.com> on 2014-01-28
      Reviewed by Anders Carlsson.
      
      * Shared/API/Cocoa/WKRemoteObjectCoder.mm:
      (encodeInvocation): Support encoding char values.
      (decodeInvocationArguments): Support decoding char values.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a94b7bcf
    • jer.noble@apple.com's avatar
      [Mac] Handle NSURLAuthenticationMethodServerTrust challenges from... · 0f65e1ad
      jer.noble@apple.com authored
      [Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
      https://bugs.webkit.org/show_bug.cgi?id=127806
      
      Reviewed by Eric Carlson.
      
      In addition to the normal "user/password" NSURLAuthenticationChallenges, the
      -resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
      ask us to confirm server certificate chains. Rather than pop up an authentication
      dialog (which won't work anyway) we will now just drop such requests and continue
      on normally.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f65e1ad
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r162987. · 910243c6
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/162987
      https://bugs.webkit.org/show_bug.cgi?id=127825
      
      Broke Mountain Lion build (Requested by andersca on #webkit).
      
      Source/JavaScriptCore:
      
      * inspector/InjectedScriptSource.js:
      (.):
      * runtime/JSObject.cpp:
      (JSC::JSObject::getOwnPropertyDescriptor):
      * runtime/PropertyDescriptor.cpp:
      * runtime/PropertyDescriptor.h:
      * runtime/PropertySlot.h:
      
      Source/WebCore:
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateAttributesHashTable):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
      (WebCore::jsTestActiveDOMObjectConstructor):
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
      (WebCore::jsTestCustomNamedGetterConstructor):
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
      (WebCore::jsTestEventConstructorConstructor):
      * bindings/scripts/test/JS/JSTestEventTarget.cpp:
      (WebCore::jsTestEventTargetConstructor):
      * bindings/scripts/test/JS/JSTestException.cpp:
      (WebCore::jsTestExceptionConstructor):
      * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
      (WebCore::jsTestGenerateIsReachableConstructor):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::jsTestInterfaceConstructor):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::jsTestMediaQueryListListenerConstructor):
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      (WebCore::jsTestNamedConstructorConstructor):
      * bindings/scripts/test/JS/JSTestNode.cpp:
      (WebCore::jsTestNodeConstructor):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjConstructor):
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
      (WebCore::jsTestOverloadedConstructorsConstructor):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
      (WebCore::jsTestTypedefsConstructor):
      * bindings/scripts/test/JS/JSattribute.cpp:
      (WebCore::jsattributeConstructor):
      * bindings/scripts/test/JS/JSreadonly.cpp:
      (WebCore::jsreadonlyConstructor):
      
      LayoutTests:
      
      * fast/dom/Window/replaceable-expected.txt:
      * fast/dom/Window/replaceable.html:
      * js/dom/getOwnPropertyDescriptor-expected.txt:
      * js/resources/getOwnPropertyDescriptor.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      910243c6
    • enrica@apple.com's avatar
      Add support for ActionSheets in WK2 for iOS. · 69719091
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127586
      <rdar://problem/15283667>
      
      Reviewed by Benjamin Poulain.
      
      This patch contains some WebCore changes required to
      implement support for ActionSheets.
      It adds copyURL implementation for iOS in the Editor
      class and fixes some bugs in the iOS specific pasteboard
      writing code.
      The changes to Localizable.strings are the result of
      running update-webkit-localizedstrings script.
      
      * English.lproj/Localizable.strings:
      * WebCore.exp.in:
      * editing/Editor.cpp:
      * editing/Editor.h:
      * editing/ios/EditorIOS.mm:
      (WebCore::Editor::writeImageToPasteboard):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::Pasteboard::write):
      * platform/ios/PlatformPasteboardIOS.mm:
      (WebCore::PlatformPasteboard::write):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69719091