From 88c2c3bed7427d7edf6d880f1eea1fce14f2eaee Mon Sep 17 00:00:00 2001
From: Emanuele Aina <emanuele.aina@collabora.com>
Date: Thu, 8 Jul 2021 22:02:39 +0200
Subject: [PATCH] test_urls: Print exceptions when validating URLs
Print the HTTP status code and the returned exception when checking
each URL, to better understand what went wrong.
Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>
---
scripts/test_urls.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/test_urls.py b/scripts/test_urls.py
index c23157453..1008f6c38 100755
--- a/scripts/test_urls.py
+++ b/scripts/test_urls.py
@@ -13,6 +13,7 @@ from urllib.parse import urlparse
import urllib3
import time
import fnmatch
+import textwrap
EXCLUDE = [
"*://lavaphabbridge.apertis.org", #
@@ -87,22 +88,27 @@ for url in urls:
sys.stdout.flush()
start = time.perf_counter()
status = None
+ resp = None
try:
resp = requests.head(url, headers=headers, allow_redirects=True, timeout=60, verify=False)
status = resp.ok
resp.close()
except Exception as e:
- pass
+ e_str = textwrap.indent(str(type(e)) + "\n" + str(e), " ")
+ print(f"ERROR(1): {url} {resp.status_code if resp else '-'}\n{e_str}")
try:
# Some servers aren't setup to handle HEAD requests, so check anything
# that's not got a 200 status code with GET as well.
if not status:
+ resp = None
resp = requests.get(url, headers=headers, allow_redirects=True, timeout=60, verify=False)
status = resp.ok
resp.close()
except Exception as e:
status = False
+ e_str = textwrap.indent(str(type(e)) + "\n" + str(e), " ")
+ print(f"ERROR(2): {url} {resp.status_code if resp else '-'}\n{e_str}")
end = time.perf_counter()
if not status:
--
GitLab