From 876f30c75748d309471d5ea50b4744e3dd9e2420 Mon Sep 17 00:00:00 2001
From: Martyn Welch <martyn.welch@collabora.com>
Date: Thu, 30 Jul 2020 17:00:14 +0100
Subject: [PATCH] Convert image paths
The PDF generator can't find the images as the paths are relate to
where Hugo will place them on the website. Tweak the path to to point
to the images. We need to convert the SVG files into something the next
step can handle. Don't leave them in the static directory in case this
results in them being exported to the website.
Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
---
scripts/hotdoc-html-2-pdf | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/scripts/hotdoc-html-2-pdf b/scripts/hotdoc-html-2-pdf
index cc1363648..98196e858 100755
--- a/scripts/hotdoc-html-2-pdf
+++ b/scripts/hotdoc-html-2-pdf
@@ -71,7 +71,7 @@ def update_local_links(elem, prefix):
link.attrib['href'] = '%s/%s' % (prefix, href)
-def convert_svg_images(elem):
+def convert_images(elem, imgdir):
imgs = elem.xpath('.//img')
for img in imgs:
src = img.attrib.get('src')
@@ -85,13 +85,14 @@ def convert_svg_images(elem):
if not url_components.path:
continue # Local url, but doesn't need updating (eg #my-anchor)
- if not url_components.path.endswith('.svg'):
- continue
+ src = 'static' + os.path.abspath(src)
+ converted = src
- converted = os.path.abspath(src) + '.pdf'
- cmd = ['/usr/bin/rsvg-convert', src, '-f', 'pdf', '-o', converted]
+ if url_components.path.endswith('.svg'):
+ converted = imgdir + "/" + os.path.basename(src) + '.pdf'
+ cmd = ['/usr/bin/rsvg-convert', src, '-f', 'pdf', '-o', converted]
- subprocess.check_call(cmd)
+ subprocess.check_call(cmd)
img.attrib['src'] = converted
@@ -112,7 +113,9 @@ def transform(args):
if args.remote_prefix:
update_local_links(body, args.remote_prefix)
- convert_svg_images(body)
+ inpath = os.path.dirname(args.input)
+ tmpdir_path = tempfile.mkdtemp(prefix=os.path.join(inpath, ''))
+ convert_images(body, tmpdir_path)
output.append('<!DOCTYPE html>')
output.append('<html lang="en">')
--
GitLab